-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace reconciler implementation with kubeflow/common JobController #1161
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
I think it is a high-priority feature for the next release. /priority p1 |
Do you have the bandwidth for this enhancement? |
Yeah. I can definitely help on that. @ChanYiLin Said he is interested in it. I will check with him and see if he's comfortable to make the change. |
Thanks /assign @Jeffwan @ChanYiLin |
Any concrete plan on this yet? @Jeffwan @ChanYiLin |
I will start working on it this week, it might take 1~2 weeks |
@ChanYiLin Sounds good. Feel free to pin me for any help. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Should we close this now? |
I think we can /cc @ChanYiLin |
Yes, we can close this now. |
In #1144, we upgrade Kubernetes to v1.16.x and update kubeflow/common to v0.3.1 which is good.
The next step, we plan to replace reconciler implementation with kubeflow/common's JobController.
in v0.3.1, I expose
ReconcileJob
,ReconcilePod
andReconcileService
methods and if TF can not use common implementation, it's fine to override the methods and customize logic.The text was updated successfully, but these errors were encountered: