Fixed broken links in pipeline sdk-overview #1768
Conversation
|
/assign @jinchihe |
|
/assign |
|
This change can be previewed at: |
| @@ -384,7 +384,7 @@ You can also choose to share your pipeline as follows: | |||
|
|
|||
| {{% alert title="More about the above workflow" color="info" %}} | |||
| For an example of the above workflow, see the | |||
| Jupyter notebook titled [KubeFlow Pipelines basic component build](https://github.com/kubeflow/pipelines/blob/master/samples/core/component_build/component_build.ipynb) on GitHub. | |||
| Jupyter notebook titled [KubeFlow Pipelines basic component build](https://github.com/kubeflow/pipelines/blob/master/samples/core/container_build/container_build.ipynb) on GitHub. | |||
There was a problem hiding this comment.
Suggestion, update the notebook title:
KubeFlow Pipelines basic component build
->
KubeFlow Pipelines container building
There was a problem hiding this comment.
Thanks @joeliedtke for your review!
I have modified the file as what you have suggested. Please review/approve. Feel free to let me know if further change is needed.
|
/lgtm Thanks for fixing these links! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joeliedtke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @joeliedtke ! |
Part of fixes for issue 1683.
In the following page: https://www.kubeflow.org/docs/pipelines/sdk/sdk-overview/
KubeFlow Pipelines basic component build -> https://github.com/kubeflow/pipelines/blob/master/samples/core/component_build/component_build.ipynb
-> 404
Under 4th "More about the above workflow"
xgboost-training-cm.py->https://github.com/kubeflow/pipelines/blob/master/samples/core/xgboost-spark/xgboost-training-cm.py -> 404
This change is