-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid URLs in kubeflow/website #1683
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
Thanks Zhenghui, this is quite useful. I don't think there is an automated
way to update the links, but periodically running this script can be super
informative to track hygiene. Hopefully we can have the links fixed up even
if it is a manual effort. Could this issue be a good candidate for "help
wanted"?
…On Wed, Feb 12, 2020 at 4:33 PM issue-label-bot[bot] < ***@***.***> wrote:
Issue-Label Bot is automatically applying the labels:
Label Probability
kind/bug 0.56
Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage <https://github.com/marketplace/issue-label-bot>,
dashboard
<https://github.com/marketplace/issue-label-botdata/kubeflow/website> and
code <https://github.com/hamelsmu/MLapp> for this bot.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1683?email_source=notifications&email_token=ACZ2UZSAWU4BFPIT2F2LWADRCSIPJA5CNFSM4KUHISW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELS5SQA#issuecomment-585488704>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ2UZWA6XEWS34CDDW2YQTRCSIPJANCNFSM4KUHISWQ>
.
|
Thanks @zhenghuiwang This is very useful indeed. @abhi-g Good idea: I've labeled this issue as "help wanted". |
The first two broken links are reported in issue #1687 as well. @sarahmaddox , I can help on this. |
Thanks @janeman98 |
It's plain text, just a custom domain example. This can be skipped.
This link need user to login AWS console and can be skipped as well. |
Removed from the list. Thanks |
I have visited and fixed all the broken urls. The only open issue is 1687 . Can we close this issue? |
Thanks @janeman98! |
@sarahmaddox: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @sarahmaddox ! |
I wrote a script to scan all
.md
files in this repository, extracthttp/https
URLs, and ping them for validation.Out of 1300+ URLs, here is a list of URLs that seem to be invalid. Warning: false negative is possible. All file path is under
kubeflow/website/content/docs
Feel free to remove any URL from this list, if it is found valid.
/cc @sarahmaddox @abhi-g
The text was updated successfully, but these errors were encountered: