New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured the website repo to allow for future i18n and content translation #1909
Conversation
/assign @joeliedtke This PR is now ready for review. Applying a hold to give us time for a careful review. @janeman98 @joeliedtke @abhi-g Please would you take a look? See the PR description for preview link and more context. |
Thanks @sarahmaddox I am looking at the preview. May I know where to find Edit this page in the preview? |
Hallo @janeman98, the link is at the top right of every page, in the same panel that shows the list of headings on the page. If you're using a small screen, the panel may not appear. Try reducing the zoom factor in your browser. |
Thanks @sarahmaddox ! I need to maximize my screen to see it. I am good now. |
I have randomly tested >40 pages in the preview. All worked as what mentioned above. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @sarahmaddox
/hold cancel Thanks @abhi-g and @janeman98 - could you re-LGTM now that I've merged with master? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix broken links becaure of kubeflow#1909. The preparation change for i18n adds an extra direcotry `en` under `content` directory. The links in README.md which point to files under `content` directory become invalid. This change fixes all those broken links by adding the `en` into the path.
Fix broken links becaure of #1909. The preparation change for i18n adds an extra direcotry `en` under `content` directory. The links in README.md which point to files under `content` directory become invalid. This change fixes all those broken links by adding the `en` into the path.
Preview: https://deploy-preview-1909--competent-brattain-de2d6d.netlify.app/
Fixes #1127
Notes:
/static/
directory so that we could share them across languages - but that would break the structure of theOWNERS
files._redirects
file needs to be in the language subdirectory. That is, for the English docs, the_redirects
file must be in/en/
./en/
directory, the Docsy logic should work. Note that it won't work until we've merged this PR. Click Edit this page on any page to see the URL constructed by the logic. Remove the/en
part of the path to make the link work in the current directory structure (before this PR is merged).