Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in README.md #2010

Merged
merged 1 commit into from Jun 26, 2020
Merged

Fix broken links in README.md #2010

merged 1 commit into from Jun 26, 2020

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Jun 22, 2020 •
edited

Fix broken links caused by #1909. The preparation change for i18n adds
an extra direcotry en under content directory. The links in README.md
which point to files under content directory become invalid. This
change fixes all those broken links by adding the en into the path.

@yhwang
fix broken links in README.md
d7b374b 
Fix broken links becaure of kubeflow#1909. The preparation change for i18n adds
an extra direcotry `en` under `content` directory. The links in README.md
which point to files under `content` directory become invalid. This
change fixes all those broken links by adding the `en` into the path.
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @yhwang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yhwang yhwang changed the title fix broken links in README.md Fix broken links in README.md Jun 22, 2020
@yhwang
Copy link
Member Author

yhwang commented Jun 23, 2020

/assign @animeshsingh

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

/lgtm

@jinchihe
Copy link
Member

/retest

@jinchihe
Copy link
Member

/approve

1 similar comment
@animeshsingh
Copy link
Contributor

/approve

@animeshsingh
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e9f337 into kubeflow:master Jun 26, 2020
@yhwang yhwang deleted the typo-broken-link branch June 26, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@animeshsingh animeshsingh

@Jeffwan Jeffwan

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yhwang @kubeflow-bot @k8s-ci-robot @Jeffwan @jinchihe @animeshsingh