-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating architecture diagram #3680
updating architecture diagram #3680
Conversation
@andreyvelich @thesuperzapper @juliusvonkohout some feedback would really be great!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @vikas-saxena02! Couple of thoughts:
-
Rename:
Kubeflow Universe -> Kubeflow Ecosystem
Kubeflow - Ecosystem -> Kubeflow Applications or Kubeflow Components (if we name if to Kubeflow components, rename small Kubeflow components box to Kubeflow Core components). -
Make the text font bigger in boxes.
-
Maybe it is better to not put names in the grey boxes (e.g. Workspaces and ML Tools). And just name it at the top of the appropriate box.
/assign @kubeflow/kubeflow-steering-committee @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-training-leads @kubeflow/wg-manifests-leads |
Regarding "Kubeflow Universe" vs "Kubeflow Ecosystem", I'm not sure that "ecosystem" accounts for stuff that is not really part of Kubeflow but is commonly used alongside it (e.g. TensorFlow / PyTorch), because it kind of makes it sound like we own them. I kind of like the word "universe" as well but I'm open to change my mind. We also might want to specify with brackets underneath each component what they actually do, similar to the less comprehensive introduction diagram that is already on the website: |
@andreyvelich I have just made the recommended changes except for Kubeflow Universe as I have same thoughts as @thesuperzapper on that one. @thesuperzapper added descriptions in brackets as you suggested. |
@thesuperzapper Yes, but ecosystem is mostly used term to explain that these ML projects have integrations with Kubeflow. |
@andreyvelich perhaps we could use the term "Kubeflow Ladscape" similar to the "CNCF Landscape": https://landscape.cncf.io/ |
Yes, maybe Landscape also could work. Then should we rename Kubeflow Components to Kubeflow Ecosystem ? |
I like "Kubeflow Ecosystem" at the top, and "Kubeflow Components" for the various KF projects. "Ecosystem" is used more than "Universe". See one example here for Spark: https://www.oreilly.com/library/view/building-data-streaming/9781787283985/81b1268e-23c2-492e-9710-2496c601d1de.xhtml |
@andreyvelich I would leave kubeflow components as it is as we use the same terminology in the structure of documentation of website. |
I agree with James, ecosystem can be interpreted differently. It doesn't necessary mean that Kubeflow implements ML libraries (e.g. PyTorch and Tensorflow). @vikas-saxena02 Maybe we can name middle box as Kubeflow Tools and in that section we can have: Kubeflow Components and External Add-Ons ? |
@andreyvelich good suggestion. I think we should rename the middle section to kubeflow tools and scaffolding in-line with current name. |
@james-jwu @andreyvelich @thesuperzapper, I was just wondering if you guys are happy for me to apply the following changes:
|
That sounds good for to @vikas-saxena02 (Middle box - Kubeflow Scaffolding) . Any thoughts @james-jwu @kubeflow/kubeflow-steering-committee ? |
Top box Kubeflow Ecosystem - SGTM Middle box - "Scaffolding" is usually a framework that is designed to expose 3rd party code as services (e.g. Spring Boot), so it's probably not a good choice. "Tools" sounds a bit peripheral to me. "Kubeflow Components and External Add-Ons" ("External" can be dropped for brevity) sounds better to me. |
@james-jwu @andreyvelich Changed Top Box to Kubeflow Ecosystem and MiddleBox to Tools as suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the following thoughts:
- I would visually highlight Kubeflow Core Components compare to External Add-Ons and Integrations.
- remove Apache MXNet since this project was deprecated.
- change HoroVod -> Horovod
- Change HuggingFace -> Hugging Face
- Do we need explanation in stack diagram for every box (e.g. Certificate Manager) ? We can always explain it separately or link to the appropriate pages.
|
I was thinking that we should use another colour for Core Components. Also, should we just remove grey boxes from Core Components and External Add-ons and just name this box at the top ? Also, we might want to avoid sharp corners like in prev diagram: https://www.kubeflow.org/docs/started/architecture/ |
Cool.... I will make these changes today!! |
@andreyvelich done :) |
@vikas-saxena02 Please can you make font bigger for Core components and External Add-ons. I think, I was using 35 or 40. |
Hi @andreyvelich do you want the font to be increased for just core components and external add-ons or everything? |
Yes, only for core and external like in my example above: #3680 (comment) |
@james-jwu done :) Apologies, I somehow missed it. |
There is a misunderstanding here. What I meant was to rename the "Tool" in th left-middle box to "Kubeflow Components and External Add-Ons". Please see my linked comment on why I think "Tool" isn't a good choice. |
/lgtm |
I recently made some changes to @vikas-saxena02 diagram to follow Kubeflow styling. |
I like the styling updates :) |
@andreyvelich It might look better with a banner version of the Kubeflow logo (rather than square). (the above image is an SVG) |
@andreyvelich just wondering if we should add Spark or Apache Spark or SparkOperator to the top left box as its now officially a part of kubeflow. Let me know your thoughts |
I applied suggested changes.
@vikas-saxena02 We will add those components when Model Registry and Spark Operator will make the first release. cc @kubeflow/wg-data-leads Please take a look again so we can merge it finally. |
57c9379
to
e0856b5
Compare
Thank you! |
e0856b5
to
aab1a6d
Compare
Signed-off-by: Vikas Saxena <vikas.saxena.2006@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
aab1a6d
to
4dcbc05
Compare
I squashed all of the commits and add @vikas-saxena02 as co-author. |
/lgtm |
Thanks everyone for your help working on this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, vikas-saxena02 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am just wondering if the team who manages the LinkedIn profile of Kubeflow Org can do a post on the updated architecture. |
@vikas-saxena02 You can reach out to Amber. |
Pull request for #3536