Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Azure Active Directory in sovereign cloud #208

Closed
karataliu opened this issue Dec 19, 2018 · 0 comments
Closed

Support Azure Active Directory in sovereign cloud #208

karataliu opened this issue Dec 19, 2018 · 0 comments

Comments

@karataliu
Copy link
Contributor

karataliu commented Dec 19, 2018 •
edited

Azure Active Directory has different instances in sovereign clouds:
https://docs.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud

And each one has got different endpoint sets, currently the code has hardcoded to the public cloud's endpoint:
https://github.com/appscode/guard/blob/0.3.0/auth/providers/azure/azure.go#L27
https://github.com/appscode/guard/blob/0.3.0/auth/providers/azure/graph/graph.go#L22

Consider introducing a parameter to support different cloud environment for Azure.
@karataliu karataliu mentioned this issue Dec 20, 2018
Merged
tamalsaha pushed a commit that referenced this issue Feb 4, 2019
@karataliu @tamalsaha
Support aad sovereign clouds (#209)
a01e2f1 
Fixes #208
tamalsaha added a commit that referenced this issue Feb 4, 2019
@tamalsaha
Document how to use Azure sovereign cloud instances
93c6798 
xref: #208

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha mentioned this issue Feb 4, 2019
Merged
tamalsaha added a commit that referenced this issue Feb 4, 2019
@tamalsaha
Document how to use Azure sovereign cloud instances (#212)
74828f4 
xref: #208

Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha added a commit to kubeguard/docs that referenced this issue Dec 12, 2023
@tamalsaha
Document how to use Azure sovereign cloud instances (#212)
3c2e3bf 
xref: kubeguard/guard#208

Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karataliu