Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aad sovereign clouds #209

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Support aad sovereign clouds #209

merged 2 commits into from
Feb 4, 2019

Conversation

karataliu
Copy link
Contributor

Fixes #208

weinong
weinong previously approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karataliu
Copy link
Contributor Author

cc @tamalsaha @amanohar

@karataliu
Copy link
Contributor Author

ping. thanks.

@tamalsaha
Copy link
Contributor

Thanks @karataliu . @amanohar, do you mind taking a look?

@karataliu
Copy link
Contributor Author

Updated. @amanohar can you take a look

@karataliu
Copy link
Contributor Author

Thanks @amanohar, @tamalsaha would you please take a look?

@karataliu
Copy link
Contributor Author

ping @tamalsaha

1 similar comment
@karataliu
Copy link
Contributor Author

ping @tamalsaha

@tamalsaha tamalsaha merged commit a01e2f1 into kubeguard:master Feb 4, 2019
@tamalsaha
Copy link
Contributor

tamalsaha commented Feb 4, 2019 •
edited

Thanks a lot @karataliu and @amanohar ! Sorry for the slow response.

@karataliu karataliu deleted the aad.sovereign branch February 18, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamalsaha tamalsaha tamalsaha approved these changes

@amanohar amanohar amanohar approved these changes

@weinong weinong weinong left review comments

@nightfury1204 nightfury1204 Awaiting requested review from nightfury1204

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karataliu @tamalsaha @weinong @amanohar