Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail the whole patch when one ModRule fails #33

Closed
vassilvk opened this issue Dec 21, 2020 · 0 comments · Fixed by #34
Closed

Do not fail the whole patch when one ModRule fails #33

vassilvk opened this issue Dec 21, 2020 · 0 comments · Fixed by #34

Comments

@vassilvk
Copy link
Member

Currently when two or more Patch ModRules match a resource, if one of the ModRules fails at runtime due to invalid definition, the other ModRules will not be applied to the resource, even they are correct.

ModRules execution should be independent from one another.
Fix this by logging failed ModRules, but do not cancel the whole patch operation for a ModRule failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent failing the whole patch for one bad ModRule kubemod/kubemod
1 participant
@vassilvk