Add force-reboot and drain timeouts to chart config and ds

[cnmcavoy]

Followup from #341, exposes all of the new cli flags to the helm chart.

[anthr76]

Would it be possible to add reboot command as well or is another PR warranted?

[evrardjp]

@anthr76 the reboot command is already flexible, in our main branch. We are just waiting for the next kubernetes kind nodes to release our recent work!

[evrardjp]

if you would like this clarification to be included in the next release (1.7.0), it's probably better to add it into another PR.

[cnmcavoy]

I'm not overly concerned, I just noticed it was slightly incorrect when doing the helm chart changes and wanted to correct it.

[bstrdsmkr]

@anthr76 the reboot command is already flexible, in our main branch. We are just waiting for the next kubernetes kind nodes to release our recent work!

I'm not sure I understand your response here -- I believe @anthr76 is asking to have the --reboot-command included as an explicit option in the chart, even though it (as are these) is already settable via extraArgs. I didn't see an explicit option in the chart in the main branch. Did I just miss it?

[anthr76]

@bstrdsmkr Is indeed correct.. Didn't see that extraArgs bit before so not totally necessary. Just a nice to have at this point.

[evrardjp]

You're right, it seems like this slipped through the cracks. PRs welcome!

[anthr76]

I'll be happy to. Any idea on when this gets merged along with the new release?

[bstrdsmkr]

as a sanity check, is there a generic way to convert between the flag name and a yaml safe name? That way you could generate them from the yaml values instead of hard coding each one

[evrardjp]

as a sanity check, is there a generic way to convert between the flag name and a yaml safe name? That way you could generate them from the yaml values instead of hard coding each one

That would be amazing, but I am not sure we have that. @ckotzbauer what do you think of the idea? We could maybe write a utility function that does that in the helm chart, and leverage it? Or is there any other way?

[evrardjp]

@cnmcavoy this will need a rebase, can you tackle it? That would be lovely.

[ckotzbauer]

@evrardjp @bstrdsmkr I think the "kebabcase" function could help us: https://helm.sh/docs/chart_template_guide/function_list/#kebabcase

[EduardFazliev]

Is there any chance that this will be merged some day? Is there a way to help to speed up the process?

[ckotzbauer]

@cnmcavoy Can you rebase this again please?
I think this should be ready to merge in general, if there are no other objections. I would be ok to include the clarification in main.go
/cc @evrardjp

[cnmcavoy]

rebased.