-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch GCP zones from API #1379
Fetch GCP zones from API #1379
Conversation
Please take a look. /hold cancel |
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
=========================================
- Coverage 73.78% 73.69% -0.1%
=========================================
Files 203 204 +1
Lines 6096 6158 +62
Branches 562 572 +10
=========================================
+ Hits 4498 4538 +40
- Misses 1371 1387 +16
- Partials 227 233 +6
Continue to review full report at Codecov.
|
Code LGTM. I'll test it. |
/retest |
1 similar comment
/retest |
/lgtm |
LGTM label has been added. Git tree hash: c34c2ad74a0bb01038f88e9963bba28b9b96730f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1321.Special notes for your reviewer:
Release note: