Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch GCP zones from API #1379

Merged
merged 8 commits into from
Jul 16, 2019
Merged

Fetch GCP zones from API #1379

merged 8 commits into from
Jul 16, 2019

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Jul 12, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1321.

Special notes for your reviewer:

Release note:

Fetch GCP zones from API.

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2019
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2019
@maciaszczykm
Copy link
Contributor Author

Please take a look.

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #1379 into master will decrease coverage by 0.09%.
The diff coverage is 44.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1379     +/-   ##
=========================================
- Coverage   73.78%   73.69%   -0.1%     
=========================================
  Files         203      204      +1     
  Lines        6096     6158     +62     
  Branches      562      572     +10     
=========================================
+ Hits         4498     4538     +40     
- Misses       1371     1387     +16     
- Partials      227      233      +6
Impacted Files Coverage Δ
src/app/shared/model/NodeProviderConstants.ts 91.3% <ø> (-0.37%) ⬇️
src/app/testing/services/api-mock.service.ts 72.63% <100%> (+0.58%) ⬆️
src/app/core/services/api/api.service.ts 35.48% <33.33%> (-0.06%) ⬇️
...node-data/gcp-node-data/gcp-node-data.component.ts 41.71% <41.66%> (+0.26%) ⬆️
src/app/core/services/wizard/provider/gcp.ts 60% <50%> (+8.48%) ⬆️
...rc/app/shared/validators/ssh-key-form.validator.ts 90.9% <0%> (ø)
...add-ssh-key-dialog/add-ssh-key-dialog.component.ts 84.61% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcba1a...1c676c5. Read the comment docs.

@floreks
Copy link
Contributor

floreks commented Jul 15, 2019

Code LGTM. I'll test it.

@floreks
Copy link
Contributor

floreks commented Jul 16, 2019

/retest

1 similar comment
@maciaszczykm
Copy link
Contributor Author

/retest

@floreks
Copy link
Contributor

floreks commented Jul 16, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c34c2ad74a0bb01038f88e9963bba28b9b96730f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@kubermatic-bot kubermatic-bot merged commit 89b20b7 into master Jul 16, 2019
@kubermatic-bot kubermatic-bot deleted the gcp-zones branch July 16, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCE] get the list of zones from API
3 participants