Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster statuses #1439

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix cluster statuses #1439

merged 1 commit into from
Jul 31, 2019

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Jul 31, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1416.

Special notes for your reviewer:

Release note:

Disabled the possibility of adding new node deployments until the cluster is fully ready.

@kubermatic-bot kubermatic-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 31, 2019
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #1439 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage    73.4%   73.35%   -0.06%     
==========================================
  Files         205      205              
  Lines        6288     6391     +103     
  Branches      582      595      +13     
==========================================
+ Hits         4616     4688      +72     
- Misses       1428     1462      +34     
+ Partials      244      241       -3
Impacted Files Coverage Δ
...tails/cluster-secrets/cluster-secrets.component.ts 88% <100%> (ø) ⬆️
...hared/utils/health-status/cluster-health-status.ts 90.47% <100%> (+7.14%) ⬆️
...uster/cluster-details/cluster-details.component.ts 70.76% <100%> (+0.69%) ⬆️
src/app/wizard/wizard.component.ts 45.23% <0%> (-1.9%) ⬇️
...-data/azure-node-data/azure-node-data.component.ts 62.37% <0%> (+0.99%) ⬆️
src/app/core/services/user/user.service.ts 58.33% <0%> (+1.66%) ⬆️
src/app/sshkey/sshkey.component.ts 90.9% <0%> (+2.5%) ⬆️
src/app/serviceaccount/serviceaccount.component.ts 77.87% <0%> (+2.6%) ⬆️
src/app/core/services/cluster/cluster.service.ts 40.94% <0%> (+4.27%) ⬆️
src/app/core/services/project/project.service.ts 50% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f51a4...108e28f. Read the comment docs.

@floreks
Copy link
Contributor

floreks commented Jul 31, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f07c3cc235d2d823065f48ca7c8a508334b755f1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@maciaszczykm
Copy link
Contributor Author

/retest

1 similar comment
@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 6aad2da into master Jul 31, 2019
@kubermatic-bot kubermatic-bot deleted the fix/cluster-status branch July 31, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Add Node Deployment button until all components are ready
3 participants