Fetch AWS sizes from the API #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
kubermatic-bot
added
size/L
|
Current view:
|
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
=========================================
Coverage ? 71.73%
=========================================
Files ? 210
Lines ? 6721
Branches ? 664
=========================================
Hits ? 4821
Misses ? 1638
Partials ? 262
Continue to review full report at Codecov.
|
Load AWS instance sizes only on component init
maciaszczykm
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
|
Please test it when reviewing. |
|
/hold API needs debugging. It fails from time to time but only on dev... |
kubermatic-bot
added
the
do-not-merge/hold
|
kubermatic/kubermatic#4203 should fix the API. /hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
# Conflicts: # src/app/core/services/wizard/provider/aws.ts # src/app/shared/entity/provider/aws/AWS.ts
|
PTAL |
kgroschoff
reviewed
Aug 30, 2019
kubermatic-bot
added
the
needs-rebase
kubermatic-bot
removed
the
needs-rebase
|
@kgroschoff PTAL, conflicts are resolved now :) |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 03c4bb3a76b91a1dad0e2ce81dc0b2cb87e49276
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgroschoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It consumes endpoints added in kubermatic/kubermatic#4166. Please wait for kubermatic/kubermatic#4192 too.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged): Fixes #1245.Special notes for your reviewer:
Release note: