Collapse extended options wizard #1609

kgroschoff · 2019-09-25T14:44:37Z

What this PR does / why we need it:
Add possibility to collapse extended options & restructure order,

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1518

Special notes for your reviewer:
Sorry for this huge PR 😞

I would suggest to use the same styling for Provider Tags as vor Node Labels. But as this will be definitely too much for this PR, I'd keep this as seperate issue.

Extremely short overview:

SetSettingsComponent includes ExtendedOptionsComponent
ExtendedOptionsComponent includes ClusterProviderOptionsComponent & NodeDataOptionsComponent

Example AWS:

Release note:

Redesign extended options in wizard

kubermatic-bot · 2019-09-25T14:44:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kgroschoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2019-09-25T14:52:30Z

Codecov Report

Merging #1609 into master will decrease coverage by 0.05%.
The diff coverage is 59.73%.

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   71.57%   71.52%   -0.06%     
==========================================
  Files         210      222      +12     
  Lines        6818     7164     +346     
  Branches      682      712      +30     
==========================================
+ Hits         4880     5124     +244     
- Misses       1671     1764      +93     
- Partials      267      276       +9

Impacted Files	Coverage Δ
...ata/packet-node-data/packet-node-data.component.ts	`58.02% <ø> (+0.55%)`	⬆️
src/app/shared/entity/NodeEntity.ts	`72.91% <ø> (ø)`	⬆️
.../app/wizard/set-settings/set-settings.component.ts	`71.42% <0%> (ø)`	⬆️
...node-data/gcp-node-data/gcp-node-data.component.ts	`41.46% <100%> (-0.39%)`	⬇️
...ta/vsphere-add-node/vsphere-node-data.component.ts	`92.3% <100%> (ø)`	⬆️
...a/node-data-options/node-data-options.component.ts	`100% <100%> (ø)`
src/app/shared/utils/common-utils.ts	`71.42% <100%> (+7.79%)`	⬆️
...ngs/provider-options/provider-options.component.ts	`100% <100%> (ø)`
...node-data/aws-node-data/aws-node-data.component.ts	`67.54% <100%> (+2.48%)`	⬆️
...ider-options/vsphere-provider-options.component.ts	`35.87% <35.87%> (ø)`
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763f04d...63c7e7b. Read the comment docs.

kgroschoff · 2019-09-26T07:10:36Z

/hold
found a issue that only appears in this branch with openstack (when using presets), will have a look

kgroschoff · 2019-09-26T07:53:45Z

/hold cancel

maciaszczykm · 2019-10-02T08:03:11Z

src/app/node-data/aws-node-data/aws-node-options/aws-node-options.component.scss

@@ -0,0 +1,3 @@
+.km-tags-in-wizard {


If it works for all kind of tags then can we move to the main app.scss?

maciaszczykm · 2019-10-02T08:04:18Z

src/app/node-data/aws-node-data/aws-node-options/aws-node-options.component.ts

+        key: new FormControl(''),
+        value: new FormControl(''),
+      }));
+    }


Can we use a separate function for tag list initialization?

maciaszczykm · 2019-10-02T08:04:41Z

src/app/node-data/azure-node-data/azure-node-data.component.ts

    } else {
-      this.azureNodeForm.controls.size.enable();
+      this.form.controls.size.enable();


maciaszczykm · 2019-10-02T08:05:54Z

src/app/node-data/azure-node-data/azure-node-options/azure-node-options.component.html

+  </div>
+
+  <div class="km-form-group-tags-header">
+    Tags


Do the tags for Azure and for example AWS work in the same way? This is not the scope of this PR but we could do it in another one and it would reduce code duplication a bit.

Yes and I'd like to style them similar to e.g. Node Labels. So probably a new component for Provider Tags, but I'd like to do this in a seperate PR, as this also will be a bigger PR.

maciaszczykm · 2019-10-02T08:06:25Z

src/app/node-data/azure-node-data/azure-node-options/azure-node-options.component.ts

+        key: new FormControl(''),
+        value: new FormControl(''),
+      }));
+    }


Can we separate to another method?

kgroschoff · 2019-10-14T14:29:59Z

@maciaszczykm PTAL :)

kgroschoff · 2019-10-18T07:14:18Z

@maciaszczykm I resolved the merge conflicts. PTAL

maciaszczykm · 2019-10-22T08:13:51Z

@kgroschoff Sorry, for the delay... I am looking on it right now.

maciaszczykm · 2019-10-22T08:42:25Z

/lgtm

Great work 👏

kubermatic-bot · 2019-10-22T08:42:29Z

LGTM label has been added.

Git tree hash: a0987f1be79f41ebce045b2c285228abc7ef33d7

kgroschoff self-assigned this Sep 25, 2019

kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 25, 2019

kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2019

kgroschoff changed the title ~~[WIP] Collapse extended options wizard~~ Collapse extended options wizard Sep 25, 2019

kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2019

kgroschoff requested review from maciaszczykm and floreks and removed request for maciaszczykm September 25, 2019 15:04

kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019

kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019

kgroschoff force-pushed the feature/collapse-extended-options-wizard branch from 45b445b to 88538c2 Compare September 26, 2019 12:37

maciaszczykm reviewed Oct 2, 2019

View reviewed changes

kgroschoff force-pushed the feature/collapse-extended-options-wizard branch from 88538c2 to c236cf3 Compare October 14, 2019 10:40

kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Oct 14, 2019

kgroschoff added 4 commits October 18, 2019 09:01

add hide extended options area

80b46a3

add azure options

4500b1c

rename digitalocean options

2a476d6

rename openstack options

d21fbb7

kgroschoff added 20 commits October 18, 2019 09:06

fix openstack provider options loading fields

a1771ff

adjust padding for openstack flavor & allocate floating ip

9da7f6c

fix padding for extended option tags

326929d

hide hint when using presets

6b18402

show correct input

552e529

disable optional fields on openstack if no valid credentials

167a839

default tags

4497a85

rename form

0cb33c6

fix tests part I

0741551

fix tests part II

c70f07d

fix merge problems

012e560

hide options

72fe590

move aws vpc to extended options

6f6bf16

correctly use aws securityGroupID

b694be5

fix unit tests

c12b1bb

fix node deployment dialog

e617647

fix: disable projects on openstack if preset is selected

93e0e3b

fix merge conflicts & add packet node options

7a20bd9

fix unit tests

3a1525d

new function for empty tag & label lists

aed130b

kgroschoff force-pushed the feature/collapse-extended-options-wizard branch from eb1cfa2 to aed130b Compare October 18, 2019 07:08

fix vsphere node options

63c7e7b

kubermatic-bot assigned maciaszczykm Oct 22, 2019

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019

kubermatic-bot merged commit 858a2d5 into master Oct 22, 2019

kubermatic-bot deleted the feature/collapse-extended-options-wizard branch October 22, 2019 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Collapse extended options wizard #1609

Collapse extended options wizard #1609

kgroschoff commented Sep 25, 2019 •

edited

Loading

kubermatic-bot commented Sep 25, 2019

codecov bot commented Sep 25, 2019 •

edited

Loading

kgroschoff commented Sep 26, 2019 •

edited

Loading

kgroschoff commented Sep 26, 2019

maciaszczykm Oct 2, 2019

maciaszczykm Oct 2, 2019

maciaszczykm Oct 2, 2019

maciaszczykm Oct 2, 2019

kgroschoff Oct 14, 2019

maciaszczykm Oct 2, 2019

kgroschoff commented Oct 14, 2019

kgroschoff commented Oct 18, 2019

maciaszczykm commented Oct 22, 2019

maciaszczykm commented Oct 22, 2019

kubermatic-bot commented Oct 22, 2019

Collapse extended options wizard #1609

Collapse extended options wizard #1609

Conversation

kgroschoff commented Sep 25, 2019 • edited Loading

kubermatic-bot commented Sep 25, 2019

codecov bot commented Sep 25, 2019 • edited Loading

Codecov Report

kgroschoff commented Sep 26, 2019 • edited Loading

kgroschoff commented Sep 26, 2019

maciaszczykm Oct 2, 2019

Choose a reason for hiding this comment

maciaszczykm Oct 2, 2019

Choose a reason for hiding this comment

maciaszczykm Oct 2, 2019

Choose a reason for hiding this comment

maciaszczykm Oct 2, 2019

Choose a reason for hiding this comment

kgroschoff Oct 14, 2019

Choose a reason for hiding this comment

maciaszczykm Oct 2, 2019

Choose a reason for hiding this comment

kgroschoff commented Oct 14, 2019

kgroschoff commented Oct 18, 2019

maciaszczykm commented Oct 22, 2019

maciaszczykm commented Oct 22, 2019

kubermatic-bot commented Oct 22, 2019

kgroschoff commented Sep 25, 2019 •

edited

Loading

codecov bot commented Sep 25, 2019 •

edited

Loading

kgroschoff commented Sep 26, 2019 •

edited

Loading