Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Pod Security Policy activation from wizard #1647

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1644

Special notes for your reviewer:

Release note:

Enabled Pod Security Policy activation from wizard.

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2019
@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #1647 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   71.67%   71.66%   -0.02%     
==========================================
  Files         211      211              
  Lines        6793     6794       +1     
  Branches      676      676              
==========================================
  Hits         4869     4869              
  Misses       1663     1663              
- Partials      261      262       +1
Impacted Files Coverage Δ
...ard/set-cluster-spec/set-cluster-spec.component.ts 88.33% <ø> (ø) ⬆️
src/app/shared/model/ClusterForm.ts 100% <ø> (ø) ⬆️
src/app/wizard/wizard.component.ts 47.2% <0%> (-0.3%) ⬇️
.../components/notification/notification.component.ts 80% <0%> (-4.45%) ⬇️
src/app/member/member.component.ts 76% <0%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86007d2...9e085e9. Read the comment docs.

@maciaszczykm maciaszczykm changed the title [WIP] Enable Pod Security Policy activation from wizard Enable Pod Security Policy activation from wizard Oct 7, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2019
@maciaszczykm
Copy link
Contributor Author

Zrzut ekranu 2019-10-7 o 11 51 05

Zrzut ekranu 2019-10-7 o 11 50 57

Zrzut ekranu 2019-10-7 o 11 50 53

@floreks
Copy link
Contributor

floreks commented Oct 7, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 288959311caf06d7f10f2f48520c80c453b5e6bb

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit c1fbf25 into master Oct 7, 2019
@kubermatic-bot kubermatic-bot deleted the feature/cluster-psp branch October 7, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable PSP also during cluster creation
3 participants