-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding addons to the clusters #1683
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have created the pull request quicker so we can discuss a few things. First of all, as I have stated in #1469 at the moment we have no images for addons and we will no be able to fully reflect the designs: @cschieder Do you have any idea how we can style the addon names for now? |
f3dc76a
to
8cda003
Compare
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
- Coverage 71.51% 71.35% -0.16%
==========================================
Files 222 224 +2
Lines 7164 7266 +102
Branches 712 722 +10
==========================================
+ Hits 5123 5185 +62
- Misses 1764 1801 +37
- Partials 277 280 +3
Continue to review full report at Codecov.
|
Disable adding addons when all are already installed
5c01941
to
e1c0c9b
Compare
Move edit and delete logic outside addon component
@maciaszczykm honestly I would leave as is except using title case/whatever capitalisation the logo uses, if possible. Do we have any estimate on when we want to add the images? |
@cschieder Unfortunately all the addons are retrieved from the API, so we cannot change the names as we don't know the original ones. I'd like to add the images sooner rather than later but there are a few things related to addons that are more important at the moment. The first of them is how we can implement the |
It's ready for a review. #1690 is a follow-up issue for this. @kgroschoff PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
/lgtm
LGTM label has been added. Git tree hash: 721e575adbf2f5a8738eb0432bab845e963ababd
|
/retest |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New changes are detected. LGTM label has been removed. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: This adds initial addons functionality.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1469. Follow up in the #1690.Special notes for your reviewer:
Release note: