Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding addons to the clusters #1683

Merged
merged 18 commits into from
Oct 22, 2019
Merged

Allow adding addons to the clusters #1683

merged 18 commits into from
Oct 22, 2019

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Oct 16, 2019

What this PR does / why we need it: This adds initial addons functionality.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1469. Follow up in the #1690.

Special notes for your reviewer:

Release note:

Allowed adding addons to the clusters.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 16, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@maciaszczykm
Copy link
Contributor Author

I have created the pull request quicker so we can discuss a few things. First of all, as I have stated in #1469 at the moment we have no images for addons and we will no be able to fully reflect the designs:

Zrzut ekranu 2019-10-16 o 12 50 15

@cschieder Do you have any idea how we can style the addon names for now?

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1683 into master will decrease coverage by 0.15%.
The diff coverage is 60.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
- Coverage   71.51%   71.35%   -0.16%     
==========================================
  Files         222      224       +2     
  Lines        7164     7266     +102     
  Branches      712      722      +10     
==========================================
+ Hits         5123     5185      +62     
- Misses       1764     1801      +37     
- Partials      277      280       +3
Impacted Files Coverage Δ
...nfirmation-dialog/confirmation-dialog.component.ts 73.68% <ø> (ø) ⬆️
...hared/utils/health-status/cluster-health-status.ts 90.47% <100%> (ø) ⬆️
src/app/testing/services/cluster-mock-service.ts 84.48% <100%> (+0.55%) ⬆️
src/app/shared/shared.module.ts 100% <100%> (ø) ⬆️
src/app/testing/services/api-mock.service.ts 73.78% <100%> (+0.51%) ⬆️
src/app/core/services/api/api.service.ts 37.06% <33.33%> (-0.08%) ⬇️
src/app/core/services/cluster/cluster.service.ts 36.73% <33.33%> (-0.35%) ⬇️
...ist/add-addon-dialog/add-addon-dialog.component.ts 57.14% <57.14%> (ø)
...ared/components/addon-list/addon-list.component.ts 60.34% <60.34%> (ø)
...uster/cluster-details/cluster-details.component.ts 68.66% <63.63%> (-0.62%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783e236...f3ea86d. Read the comment docs.

Marcin Maciaszczyk added 3 commits October 16, 2019 13:18
Disable adding addons when all are already installed
Marcin Maciaszczyk added 3 commits October 17, 2019 11:30
@cschieder
Copy link
Contributor

@maciaszczykm honestly I would leave as is except using title case/whatever capitalisation the logo uses, if possible. Do we have any estimate on when we want to add the images?

@maciaszczykm
Copy link
Contributor Author

@cschieder Unfortunately all the addons are retrieved from the API, so we cannot change the names as we don't know the original ones.

I'd like to add the images sooner rather than later but there are a few things related to addons that are more important at the moment. The first of them is how we can implement the Variables edition (this is basically an object without any structure and normal form will not help us here).

@maciaszczykm maciaszczykm changed the title [WIP] Allow adding addons to the clusters Allow adding addons to the clusters Oct 21, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2019
@maciaszczykm
Copy link
Contributor Author

Zrzut ekranu 2019-10-22 o 10 16 40

Zrzut ekranu 2019-10-22 o 10 16 30

Zrzut ekranu 2019-10-22 o 10 16 09

Zrzut ekranu 2019-10-22 o 10 14 54

Zrzut ekranu 2019-10-22 o 10 14 50

Zrzut ekranu 2019-10-22 o 10 14 45

It's ready for a review. #1690 is a follow-up issue for this.

@kgroschoff PTAL

Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 721e575adbf2f5a8738eb0432bab845e963ababd

@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@maciaszczykm maciaszczykm added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 66d6b38 into master Oct 22, 2019
@kubermatic-bot kubermatic-bot deleted the feature/addons branch October 22, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable/disable Addons per cluster in the UI
5 participants