Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v2.12] Fix adding node deployments for openstack #1836

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Nov 29, 2019

What this PR does / why we need it:
Fixes adding new node deployments for openstack clusters.

Release note:

Fixed an issue with adding new node deployments on Openstack

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 29, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2019
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.12@c140939). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/v2.12    #1836   +/-   ##
================================================
  Coverage                 ?   71.18%           
================================================
  Files                    ?      224           
  Lines                    ?     7312           
  Branches                 ?      729           
================================================
  Hits                     ?     5205           
  Misses                   ?     1823           
  Partials                 ?      284
Impacted Files Coverage Δ
...enstack-node-data/openstack-node-data.component.ts 62.79% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c140939...4f6c377. Read the comment docs.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91f564736ccc856381e9a1c0b01c2da6f5a3af63

@kubermatic-bot kubermatic-bot merged commit 4f5c278 into release/v2.12 Nov 29, 2019
@kubermatic-bot kubermatic-bot deleted the fix/add-nd branch November 29, 2019 10:42
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants