Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user panel to new component #2399

Merged
merged 10 commits into from
Jun 19, 2020
Merged

Move user panel to new component #2399

merged 10 commits into from
Jun 19, 2020

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it: It is a copy of #2388. I will add next PRs from the new fork.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1979

Special notes for your reviewer:

Release note:

Updated user panel styling.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 19, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2020
@maciaszczykm maciaszczykm reopened this Jun 19, 2020
@kgroschoff
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54355dba562c321b811dff241bff0051627e75ab

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@maciaszczykm maciaszczykm added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@maciaszczykm maciaszczykm added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@maciaszczykm maciaszczykm added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@kubermatic-bot kubermatic-bot merged commit b35128c into master Jun 19, 2020
@kubermatic-bot kubermatic-bot deleted the feature/user-panel branch June 19, 2020 12:08
@maciaszczykm
Copy link
Contributor Author

/cherry-pick release/v2.14

@kubermatic-bot
Copy link
Contributor

@maciaszczykm: #2399 failed to apply on top of branch "release/v2.14":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	src/app/core/components/navigation/navigation.component.spec.ts
M	src/app/core/components/navigation/navigation.component.ts
M	src/app/core/core.module.ts
Falling back to patching base and 3-way merge...
Auto-merging src/app/core/core.module.ts
CONFLICT (content): Merge conflict in src/app/core/core.module.ts
Auto-merging src/app/core/components/user-panel/user-panel.component.spec.ts
CONFLICT (content): Merge conflict in src/app/core/components/user-panel/user-panel.component.spec.ts
Auto-merging src/app/core/components/navigation/navigation.component.ts
CONFLICT (content): Merge conflict in src/app/core/components/navigation/navigation.component.ts
Patch failed at 0001 Create user panel component

In response to this:

/cherry-pick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update user menu styling
4 participants