Use new node data #2481

floreks · 2020-07-13T11:41:38Z

What this PR does / why we need it:
This PR replaces currently used node data and wizard with new versions.

Updated providers that use new node data:

TODO:

Replace old wizard/node-data with new versions

Release note:

Use the new wizard and node data

Use new node data for AWS Add alibaba support Fix rebase issues Add azure support

kubermatic-bot · 2020-07-13T11:41:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

maciaszczykm · 2020-07-13T12:13:53Z

Alibaba Cloud doesn't load correct instance type on edits.
Error 500: cannot decode patched cluster: json: cannot unmarshal number into Go struct field KubevirtNodeSpec.spec.template.cloud.kubevirt.cpus of type string occurs on KubeVirt edits.

codecov · 2020-07-14T12:58:50Z

Codecov Report

@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
- Coverage   57.14%   51.13%   -6.01%     
==========================================
  Files         283      226      -57     
  Lines       11078     7867    -3211     
  Branches     1558      925     -633     
==========================================
- Hits         6330     4023    -2307     
+ Misses       4737     3842     -895     
+ Partials       11        2       -9

Impacted Files	Coverage Δ
src/app/core/services/api/api.service.ts	`5.71% <0.00%> (ø)`
src/app/core/services/auth/auth.guard.ts	`23.80% <0.00%> (+0.55%)`	⬆️
src/app/node-data/config.ts	`100.00% <ø> (ø)`
src/app/shared/utils/common-utils.ts	`23.07% <0.00%> (-17.67%)`	⬇️
src/app/wizard/config.ts	`100.00% <ø> (ø)`
src/app/wizard/step/base.ts	`22.22% <ø> (ø)`
src/app/node-data/service/provider/azure.ts	`18.33% <12.50%> (ø)`
src/app/node-data/service/provider/aws.ts	`20.37% <13.04%> (ø)`
src/app/node-data/service/provider/gcp.ts	`14.47% <14.47%> (ø)`
src/app/node-data/service/provider/openstack.ts	`19.04% <14.81%> (ø)`
... and 59 more

Continue to review full report at Codecov.

maciaszczykm · 2020-07-14T13:43:39Z

/lgtm

kubermatic-triage-bot · 2020-07-15T03:37:35Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T03:37:38Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T05:01:34Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T05:01:37Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T06:25:34Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T06:25:37Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T07:49:35Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T07:49:38Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T09:13:45Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T09:13:48Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floreks · 2020-07-15T09:26:24Z

/hold

floreks · 2020-07-15T13:21:27Z

/hold cancel

maciaszczykm · 2020-07-15T13:34:54Z

/lgtm

kubermatic-bot · 2020-07-15T13:34:58Z

LGTM label has been added.

Git tree hash: 98e1b48084769286d07b9d475b7be34591cef4e4

maciaszczykm · 2020-07-15T13:46:21Z

/test test-e2e
/test test-e2e-ce

kubermatic-triage-bot · 2020-07-15T15:50:36Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T15:50:39Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T16:11:36Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T16:11:39Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubermatic-triage-bot · 2020-07-15T16:32:35Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

kubermatic-bot · 2020-07-15T16:32:37Z

@kubermatic-triage-bot:

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sebastian Florek and others added 12 commits July 13, 2020 13:40

Update node data for DigitalOcean

fd9effd

Use new node data for AWS Add alibaba support Fix rebase issues Add azure support

Support GCP node data

5f8de4a

Fix conflicts

0658715

Add support for Hetzner

d07202d

Support KubeVirt

8cc8a3a

Add support for VSphere

5f4a7c2

Remove old wizard/node-data

098b414

Add Packet support

6619fa3

Add Openstack support

ce22649

Resolve conflicts

fb14e12

Fix static check

b220b66

Fix DO, KubeVirt issues

6f89c0c

kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 13, 2020

Sebastian Florek added 8 commits July 13, 2020 16:11

Various fixes

322464c

Update recreation warning logic

75b813b

Openstack fixes

4bab223

Update providers initialization

870270d

Update async data for dialog mode

6a5a1aa

Fixes and improvements

89cd7e4

Fix imports

c827294

Fix unit tests

86fa04b

kubermatic-bot assigned maciaszczykm Jul 14, 2020

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020

kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020

Fix e2e tests

3c0d5d6

kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020

Merge remote-tracking branch 'upstream/master' into wizard/node-data

7395428

kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020

kubermatic-bot merged commit a0fb023 into kubermatic:master Jul 15, 2020

floreks deleted the wizard/node-data branch July 15, 2020 19:34

maciaszczykm mentioned this pull request Aug 28, 2020

UI/UX Fixes & Discuss #2564

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new node data #2481

Use new node data #2481

floreks commented Jul 13, 2020 •

edited

Loading

kubermatic-bot commented Jul 13, 2020

maciaszczykm commented Jul 13, 2020 •

edited by floreks

Loading

codecov bot commented Jul 14, 2020 •

edited

Loading

maciaszczykm commented Jul 14, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

floreks commented Jul 15, 2020

floreks commented Jul 15, 2020

maciaszczykm commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

maciaszczykm commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

Use new node data #2481

Use new node data #2481

Conversation

floreks commented Jul 13, 2020 • edited Loading

kubermatic-bot commented Jul 13, 2020

maciaszczykm commented Jul 13, 2020 • edited by floreks Loading

codecov bot commented Jul 14, 2020 • edited Loading

Codecov Report

maciaszczykm commented Jul 14, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

floreks commented Jul 15, 2020

floreks commented Jul 15, 2020

maciaszczykm commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

maciaszczykm commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

kubermatic-triage-bot commented Jul 15, 2020

kubermatic-bot commented Jul 15, 2020

floreks commented Jul 13, 2020 •

edited

Loading

maciaszczykm commented Jul 13, 2020 •

edited by floreks

Loading

codecov bot commented Jul 14, 2020 •

edited

Loading