-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EOL info component #2520
Add EOL info component #2520
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
==========================================
+ Coverage 52.44% 52.77% +0.32%
==========================================
Files 226 229 +3
Lines 7936 8012 +76
Branches 927 938 +11
==========================================
+ Hits 4162 4228 +66
- Misses 3771 3781 +10
Partials 3 3
Continue to review full report at Codecov.
|
What about a case where there are multiple clusters within the project and some of them are near EOL and some of them use already deprecated versions? Should we show multiple warnings/errors? Show only error with generic information about status? Also, I think that this would have to be handled by the API directly since we do not get information about the clusters on the project list view and we shouldn't get all the clusters for all projects as it would be a very expensive operation. We'd need to modify the existing project list endpoint probably. |
@cschieder PTAL at new screenshots. |
/lgtm |
LGTM label has been added. Git tree hash: a18b3d8d25ef8f46c29d723d15fb71231a512658
|
/test pre-dashboard-test-e2e |
/hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: 405f8c2f7195504796db2dbb84f0f9377d92957c
|
What this PR does / why we need it:
Features
<1.16.0
are highlighted in the UI with a warningin the project list, projects containing EOL clusters are highlighted similarly<1.16.0
is relatively easy to change in the future### Design@cschieder I could use some ideas here. We are already showing a warning icon for container linux clusters. I don't have any good ideas on how to nicely show more warnings/errors. We also need to differentiate between versions where end-of-life date has already passed (error) and not yet passed (warning).
# Update 2
Which issue(s) this PR fixes:
Fixes #2497
Release note: