Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose smallest/cheapest instance as the default one #2541

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Choose smallest/cheapest instance as the default one #2541

merged 1 commit into from
Aug 6, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Aug 5, 2020

What this PR does / why we need it:

  • Updated providers logic in the wizard to choose the smallest/cheapest instance by default
  • Updated display name format to show all information after selecting an instance
  • Fixed an issue with triggering refresh of sizes and related endpoints when datacenters are refreshed

Release note:

Cheapest/smallest provider instance will be chosen by default in the wizard

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 5, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #2541 into master will decrease coverage by 0.33%.
The diff coverage is 5.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
- Coverage   51.13%   50.79%   -0.34%     
==========================================
  Files         226      226              
  Lines        7867     8961    +1094     
  Branches      925     1133     +208     
==========================================
+ Hits         4023     4552     +529     
- Misses       3842     4407     +565     
  Partials        2        2              
Impacted Files Coverage Δ
src/app/node-data/service/provider/alibaba.ts 17.46% <0.00%> (ø)
src/app/node-data/service/provider/aws.ts 20.37% <0.00%> (ø)
src/app/node-data/service/provider/azure.ts 18.33% <0.00%> (ø)
src/app/node-data/service/provider/digitalocean.ts 33.33% <0.00%> (ø)
src/app/node-data/service/provider/gcp.ts 14.47% <0.00%> (ø)
src/app/node-data/service/provider/hetzner.ts 37.50% <0.00%> (ø)
src/app/node-data/service/provider/openstack.ts 19.04% <0.00%> (ø)
src/app/node-data/service/provider/packet.ts 31.42% <0.00%> (ø)
src/app/shared/utils/common-utils.ts 26.66% <50.00%> (+3.58%) ⬆️
...ter-details/edit-sshkeys/edit-sshkeys.component.ts 34.90% <0.00%> (-6.66%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d31f5...43c8aa2. Read the comment docs.

@floreks floreks requested a review from kgroschoff August 6, 2020 08:10
@floreks floreks self-assigned this Aug 6, 2020
@kgroschoff
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d7be6cc64d347580ecb841f01c41bae1a34c229

@floreks
Copy link
Contributor Author

floreks commented Aug 6, 2020

NPM has some issues and tests can't download dependencies. We'll have to wait.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floreks
Copy link
Contributor Author

floreks commented Aug 6, 2020

/retest

2 similar comments
@floreks
Copy link
Contributor Author

floreks commented Aug 6, 2020

/retest

@floreks
Copy link
Contributor Author

floreks commented Aug 6, 2020

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit e0018fb into kubermatic:master Aug 6, 2020
@floreks floreks deleted the wizard/cheapest-nodes branch August 6, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants