Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external clusters support #2608

Merged

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Sep 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2604

Special notes for your reviewer:

Release note:

Added external clusters support.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 8, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2020
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2020
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review September 15, 2020 08:05
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @floreks

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #2608 into master will decrease coverage by 0.49%.
The diff coverage is 25.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   52.91%   52.42%   -0.50%     
==========================================
  Files         232      234       +2     
  Lines        8079     8208     +129     
  Branches      989     1004      +15     
==========================================
+ Hits         4275     4303      +28     
- Misses       3801     3902     +101     
  Partials        3        3              
Impacted Files Coverage Δ
...nt-details/machine-deployment-details.component.ts 40.17% <0.00%> (ø)
...app/core/services/page-title/page-title.service.ts 21.53% <0.00%> (-3.03%) ⬇️
src/app/shared/entity/cluster.ts 63.55% <0.00%> (-0.55%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
src/app/shared/utils/node-utils/node-utils.ts 4.16% <4.16%> (ø)
src/app/core/services/cluster/cluster.service.ts 17.85% <17.77%> (-2.56%) ⬇️
...r/cluster-details/node-list/node-list.component.ts 79.20% <25.00%> (+12.82%) ⬆️
...app/cluster/cluster-list/cluster-list.component.ts 67.22% <40.00%> (-8.27%) ⬇️
...mponents/external-cluster-data-dialog/component.ts 47.36% <47.36%> (ø)
...luster/cluster-details/version-picker/component.ts 81.53% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87be704...17c8c84. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/retest

1 similar comment
@maciaszczykm
Copy link
Contributor Author

/retest

@floreks
Copy link
Contributor

floreks commented Sep 15, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5acc62ec194ddb84dc9c2c605599520cb6614eb

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit d243e07 into kubermatic:master Sep 15, 2020
@maciaszczykm maciaszczykm deleted the feature/external-clusters branch September 16, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add external clusters support
4 participants