-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix call order in the SSH key view #2645
Fix call order in the SSH key view #2645
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @kgroschoff |
/cherrypick release/v2.15 |
@maciaszczykm: once the present PR merges, I will cherry-pick it on top of release/v2.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
- Coverage 52.47% 52.23% -0.24%
==========================================
Files 234 234
Lines 8191 8372 +181
Branches 998 1023 +25
==========================================
+ Hits 4298 4373 +75
- Misses 3890 3995 +105
- Partials 3 4 +1
Continue to review full report at Codecov.
|
/retest |
I'm still able to see the ssh keys, but not to add a new one. Is this meant by Apart from that, code looks good |
Yes, I think so. The view rights are here and backend also supports them. Only the add, edit and delete should be blocked and it wasn't working because of wrong initialization. |
/lgtm |
LGTM label has been added. Git tree hash: 0a5d5e8d491da1965475a980b9ee67f73f9bb767
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@maciaszczykm: new pull request created: #2649 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2564
Special notes for your reviewer:
Release note: