Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call order in the SSH key view #2645

Merged

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2564

Special notes for your reviewer:

Release note:

Fix loading of the access rights in the SSH keys view.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @kgroschoff

@maciaszczykm
Copy link
Contributor Author

/cherrypick release/v2.15

@kubermatic-bot
Copy link
Contributor

@maciaszczykm: once the present PR merges, I will cherry-pick it on top of release/v2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #2645 into master will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2645      +/-   ##
==========================================
- Coverage   52.47%   52.23%   -0.24%     
==========================================
  Files         234      234              
  Lines        8191     8372     +181     
  Branches      998     1023      +25     
==========================================
+ Hits         4298     4373      +75     
- Misses       3890     3995     +105     
- Partials        3        4       +1     
Impacted Files Coverage Δ
src/app/sshkey/sshkey.component.ts 74.72% <100.00%> (-0.28%) ⬇️
...error-notifications/error-notifications.service.ts 27.58% <0.00%> (-7.42%) ⬇️
src/app/core/services/params/params.service.ts 50.00% <0.00%> (-4.17%) ⬇️
src/app/testing/services/settings-mock.service.ts 78.57% <0.00%> (-3.25%) ⬇️
src/app/core/services/cluster/cluster.service.ts 15.34% <0.00%> (-2.52%) ⬇️
...t/edit-addon-dialog/edit-addon-dialog.component.ts 31.11% <0.00%> (-2.23%) ⬇️
...all-addon-dialog/install-addon-dialog.component.ts 22.41% <0.00%> (-1.83%) ⬇️
...app/cluster/cluster-list/cluster-list.component.ts 64.97% <0.00%> (-1.70%) ⬇️
...d-machine-network/add-machine-network.component.ts 61.90% <0.00%> (-0.89%) ⬇️
src/app/project/project.module.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e543d5...4985674. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/retest

@kgroschoff
Copy link
Contributor

I'm still able to see the ssh keys, but not to add a new one. Is this meant by User with viewer role sees ssh key management as not greyed out in ui?
Asking because when the whole user management was added, this was the requested behaviour: "sshkeys": {"view": true, "edit": false, "create": false, "delete": false}. We obviously could change that. Just wondering about the issue 😅

ssh

Apart from that, code looks good

@maciaszczykm
Copy link
Contributor Author

Is this meant by User with viewer role sees ssh key management as not greyed out in ui?

Yes, I think so. The view rights are here and backend also supports them. Only the add, edit and delete should be blocked and it wasn't working because of wrong initialization.

@kgroschoff
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a5d5e8d491da1965475a980b9ee67f73f9bb767

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@maciaszczykm: new pull request created: #2649

In response to this:

/cherrypick release/v2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maciaszczykm maciaszczykm deleted the fix/sshkeys-group-config branch July 26, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX Fixes & Discuss
4 participants