Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark addons in deletion #2674

Merged

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2650

Special notes for your reviewer:

Release note:

Display deletion state of accessible addons.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @kgroschoff @floreks

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2674 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
- Coverage   52.42%   52.41%   -0.02%     
==========================================
  Files         234      234              
  Lines        8213     8215       +2     
  Branches      990      991       +1     
==========================================
  Hits         4306     4306              
- Misses       3904     3906       +2     
  Partials        3        3              
Impacted Files Coverage Δ
...ared/components/addon-list/addon-list.component.ts 19.56% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73b442...0d36d01. Read the comment docs.

@floreks
Copy link
Contributor

floreks commented Sep 28, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e36a6a7c47e98c1d77a2b15ed18fd37750aae53

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@floreks
Copy link
Contributor

floreks commented Sep 28, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51d394984aa6bf1a57ab2f6d2ba3e47e47dc3bb9

@kubermatic-bot kubermatic-bot merged commit ea47596 into kubermatic:master Sep 28, 2020
@maciaszczykm maciaszczykm deleted the feature/deleting-addons branch September 28, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display deletion state of accessible addons
4 participants