Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Openstack variables #2781

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Add support for new Openstack variables #2781

merged 3 commits into from
Nov 13, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Nov 10, 2020

What this PR does / why we need it:
Added support for 2 new Openstack fields.

  • instanceReadyCheckPeriod
  • instanceReadyCheckTimeout

Related to kubermatic/kubermatic#6139.

Zrzut ekranu z 2020-11-10 11-55-46

Zrzut ekranu z 2020-11-10 11-32-54

Zrzut ekranu z 2020-11-10 11-35-11

Release note:

Add support for 'instanceReadyCheckPeriod' and 'instanceReadyCheckTimeout' to the Openstack provider.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 10, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2781 (4c861c6) into master (24fa837) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2781      +/-   ##
==========================================
+ Coverage   52.34%   52.35%   +0.01%     
==========================================
  Files         234      234              
  Lines        8222     8224       +2     
  Branches      939      939              
==========================================
+ Hits         4304     4306       +2     
  Misses       3915     3915              
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/entity/node.ts 45.45% <ø> (ø)
src/app/testing/fake-data/node.fake.ts 68.18% <ø> (ø)
src/app/shared/entity/version-info.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fa837...4c861c6. Read the comment docs.

Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 320d8347bec12683c097470a528fbeebc8b8579e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants