Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chip and eol badge styling #2841

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Update chip and eol badge styling #2841

merged 1 commit into from
Dec 7, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Dec 7, 2020

What this PR does / why we need it:
Updated styles that were not migrated to new theming approach.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2829

Release note:

Fix end of life chip/badge styling

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 7, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #2841 (6e35105) into master (a205045) will decrease coverage by 1.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2841      +/-   ##
==========================================
- Coverage   52.34%   51.19%   -1.16%     
==========================================
  Files         234      234              
  Lines        8222     8820     +598     
  Branches      939     1014      +75     
==========================================
+ Hits         4304     4515     +211     
- Misses       3915     4304     +389     
+ Partials        3        1       -2     
Impacted Files Coverage Δ
src/app/config.service.ts 29.72% <100.00%> (ø)
...hine-deployment-details/cluster-panel/component.ts 52.94% <0.00%> (-11.35%) ⬇️
src/app/cluster/cluster-details/rbac/component.ts 34.02% <0.00%> (-9.46%) ⬇️
...uster-details/machine-deployment-list/component.ts 31.73% <0.00%> (-9.06%) ⬇️
...ster-details/machine-networks-display/component.ts 37.03% <0.00%> (-8.42%) ⬇️
.../cluster/cluster-details/revoke-token/component.ts 30.95% <0.00%> (-7.29%) ⬇️
.../cluster/cluster-details/edit-sshkeys/component.ts 37.38% <0.00%> (-6.37%) ⬇️
src/app/core/interceptors/loader/interceptor.ts 31.81% <0.00%> (-5.69%) ⬇️
...ails/edit-sshkeys/add-cluster-sshkeys/component.ts 40.27% <0.00%> (-5.34%) ⬇️
src/app/cluster/cluster-details/component.ts 49.80% <0.00%> (-5.34%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a205045...6e35105. Read the comment docs.

@floreks
Copy link
Contributor Author

floreks commented Dec 7, 2020

/retest

@maciaszczykm
Copy link
Contributor

/lgtm

Update the release note so its clear what badge was changed.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f12e99498504394dd600c75462c9580aabd4d351

@kubermatic-bot kubermatic-bot merged commit ead6c17 into kubermatic:master Dec 7, 2020
@floreks floreks deleted the fix/eol branch December 7, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End of life badge is not styled
3 participants