-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable User SSH Key Agent from the cluster wizard #3025
Add option to disable User SSH Key Agent from the cluster wizard #3025
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Skipping CI for Draft Pull Request. |
/assign @floreks @kgroschoff |
/cherry-pick release/v2.16 |
@maciaszczykm: once the present PR merges, I will cherry-pick it on top of release/v2.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@moadqassem Please check if it looks okay for you. |
Codecov Report
@@ Coverage Diff @@
## master #3025 +/- ##
=======================================
Coverage 51.74% 51.74%
=======================================
Files 238 238
Lines 8370 8370
Branches 1027 1027
=======================================
Hits 4331 4331
Misses 4036 4036
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
(feel cancel to cancel when everything is ok)
LGTM label has been added. Git tree hash: bf6b4de41c85cb5d4de7f5e27f1785f329296240
|
/retest |
/hold cancel @kgroschoff I've applied @moadqassem suggestion in the last commit. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6006bf354f4fbc3e6bcb1eda334b0616341abdcc
|
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@maciaszczykm: new pull request created: #3026 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2986
Fixes kubermatic/kubermatic#6383
Special notes for your reviewer:
Release note: