Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated kubeadm instructions #3114

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2771

Special notes for your reviewer:

Release note:

Remove duplicated KubeAdm hints from cluster page.

/cherrypick release/v2.16

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 26, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2021
@maciaszczykm
Copy link
Contributor Author

/cherrypick release/v2.16
/assign @kgroschoff @floreks

@kubermatic-bot
Copy link
Contributor

@maciaszczykm: once the present PR merges, I will cherry-pick it on top of release/v2.16 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.16
/assign @kgroschoff @floreks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a35781330bcf3b869438a7253e36f7fbf038b617

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #3114 (7f51259) into master (a65af5a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3114      +/-   ##
==========================================
+ Coverage   51.72%   51.73%   +0.01%     
==========================================
  Files         244      244              
  Lines        8545     8547       +2     
  Branches      886      886              
==========================================
+ Hits         4420     4422       +2     
  Misses       4121     4121              
  Partials        4        4              
Impacted Files Coverage Δ
src/app/member/add-member/component.ts 95.00% <ø> (ø)
src/app/core/module.ts 98.03% <100.00%> (ø)
src/app/member/edit-member/component.ts 95.65% <100.00%> (ø)
src/app/member/member.component.ts 59.82% <100.00%> (+0.34%) ⬆️
src/app/shared/shared.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63ad42...7f51259. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-bot
Copy link
Contributor

@maciaszczykm: new pull request created: #3115

In response to this:

/cherrypick release/v2.16
/assign @kgroschoff @floreks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maciaszczykm maciaszczykm deleted the fix/remove-deuplicated-kubeadm-info branch July 26, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Information not displayed for kubeadm nodes
4 participants