Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cri-tools on Amazon Linux 2 #1282

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Install cri-tools on Amazon Linux 2 #1282

merged 2 commits into from
Mar 19, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 19, 2021

What this PR does / why we need it:

Amazon Linux 2 doesn't install crictl by default. We use crictl to restart the API server if it's affected by #1222. Additionally, kubeadm verifies is crictl present if containerd is used.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1281

Does this PR introduce a user-facing change?:

Install cri-tools (crictl) on Amazon Linux 2. This fixes the issue with provisioning Kubernetes and Amazon EKS-D clusters on Amazon Linux 2

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg March 19, 2021 13:55
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 19, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2021

/hold
to manually test the changes

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b15920e1e2356f581fea6b6100138cbd09525162

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2021
@xmudrii xmudrii requested a review from kron4eg March 19, 2021 14:04
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4930b4fdc0562c09c32c5708a51e21b279263310

@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2021

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2021

/retest
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021
@kubermatic-bot kubermatic-bot merged commit 1a5b1b0 into master Mar 19, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Mar 19, 2021
@kubermatic-bot kubermatic-bot deleted the amzn2-cri-tools branch March 19, 2021 15:53
@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2021

/cherrypick release/v1.2

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1283

In response to this:

/cherrypick release/v1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
* upstream/master: (23 commits)
  Use spot instances for E2E on AWS (kubermatic#1310)
  Add Kubernetes 1.21 presubmits (kubermatic#1312)
  Add Kubernetes 1.21 binaries to the kubeone-e2e image (kubermatic#1311)
  [Azure] Added 30 second delay in output so that publicIP for Azure VM is available (kubermatic#1306)
  Remove e2e build tag (kubermatic#1305)
  Automate certificates renew (kubermatic#1300)
  Disable repo_gpgcheck for the Kubernetes yum repo (kubermatic#1304)
  Unattended upgrades addon (kubermatic#1291)
  Add the changelog for the v1.2.1 release (kubermatic#1292)
  Use admissionregistration v1 (kubermatic#1290)
  Upgrade machinecontroller to v1.27.4 (kubermatic#1288)
  Install cri-tools on Amazon Linux 2 (kubermatic#1282)
  Add the changelog for the v1.2.0 release (kubermatic#1275)
  Upgrade dependencies (kubermatic#1279)
  Use machinecontroller v1.27.1 to fix issue with flatcar (kubermatic#1276)
  shfmt (kubermatic#1274)
  Upgrade machinecontroller to v1.27.0 (kubermatic#1272)
  Add the changelog for the v1.2.0-rc.1 release (kubermatic#1270)
  Update E2E tests to use Go 1.16.1 (kubermatic#1268)
  Update the kubeone-e2e image and build jobs to Go 1.16.1 (kubermatic#1267)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Linux2 is missing crictl to run KubeOne installation of Controlplane
3 participants