-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate certificates renew #1300
Conversation
When upgrade --force or apply --force-upgrade are used. Signed-off-by: Artiom Diomin <kron82@gmail.com>
/retest |
Signed-off-by: Artiom Diomin <kron82@gmail.com>
/retest |
Signed-off-by: Artiom Diomin <kron82@gmail.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be missing one important step here. What about restarting the API server, controller manager, etcd, and other relevant components? AFAIK, if we don't restart those components, they will still use the old certificates.
I'm not sure but seems like apiserver observes the certificate files and restart its listener or it's |
Signed-off-by: Artiom Diomin <kron82@gmail.com>
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 61dfc6a94807c8c58ffcaa9a652cb7a8dffd5a9e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upstream/master: (23 commits) Use spot instances for E2E on AWS (kubermatic#1310) Add Kubernetes 1.21 presubmits (kubermatic#1312) Add Kubernetes 1.21 binaries to the kubeone-e2e image (kubermatic#1311) [Azure] Added 30 second delay in output so that publicIP for Azure VM is available (kubermatic#1306) Remove e2e build tag (kubermatic#1305) Automate certificates renew (kubermatic#1300) Disable repo_gpgcheck for the Kubernetes yum repo (kubermatic#1304) Unattended upgrades addon (kubermatic#1291) Add the changelog for the v1.2.1 release (kubermatic#1292) Use admissionregistration v1 (kubermatic#1290) Upgrade machinecontroller to v1.27.4 (kubermatic#1288) Install cri-tools on Amazon Linux 2 (kubermatic#1282) Add the changelog for the v1.2.0 release (kubermatic#1275) Upgrade dependencies (kubermatic#1279) Use machinecontroller v1.27.1 to fix issue with flatcar (kubermatic#1276) shfmt (kubermatic#1274) Upgrade machinecontroller to v1.27.0 (kubermatic#1272) Add the changelog for the v1.2.0-rc.1 release (kubermatic#1270) Update E2E tests to use Go 1.16.1 (kubermatic#1268) Update the kubeone-e2e image and build jobs to Go 1.16.1 (kubermatic#1267) ...
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1297
Does this PR introduce a user-facing change?: