Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon installer controller: update existing addons if needed #5432

Merged
merged 1 commit into from
Jun 25, 2020
Merged

addon installer controller: update existing addons if needed #5432

merged 1 commit into from
Jun 25, 2020

Conversation

multi-io
Copy link
Contributor

@multi-io multi-io commented May 22, 2020 •
edited by kdomanski
Loading

Signed-off-by: Olaf Klischat o.klischat@syseleven.de

What this PR does / why we need it:

This extends the addon installer controller so it not only installs default addons if they don't exist, but also updates them in case the in-cluster resource isn't the same as the one from the DefaultKubernetesAddons list. This became necessary for us after #5193 and was mentioned briefly in #5193 (comment).

Documentation:

Does this PR introduce a user-facing change?:

Existing default addons will be updated if their definition is changed.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/lifecycle needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2020
@kubermatic-bot
Copy link
Contributor

Hi @multi-io. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2020
@kdomanski
Copy link
Contributor

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2020
@kdomanski
Copy link
Contributor

pkg/controller/seed-controller-manager/addoninstaller/addoninstaller_controller_test.go:77: File is not gofmt-ed with -s (gofmt)

@multi-io
addon installer controller: update existing addons if needed
6b85146 
Signed-off-by: Olaf Klischat <o.klischat@syseleven.de>
@multi-io multi-io force-pushed the addon-installer-update-existing-addons branch from 2d8e381 to 6b85146 Compare June 4, 2020 09:30
@multi-io
Copy link
Contributor Author

multi-io commented Jun 4, 2020 •
edited
Loading

Rebased, formatting fixed.

@multi-io
Copy link
Contributor Author

multi-io commented Jun 7, 2020

/retest

@kdomanski
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab34814bba6584020c41496062fdebaf274eb8f8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdomanski, multi-io

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@kdomanski
Copy link
Contributor

/retest

@kubermatic-bot kubermatic-bot merged commit 599ee3b into kubermatic:master Jun 25, 2020
@kubermatic-bot kubermatic-bot added this to the v2.15 milestone Jun 25, 2020
moelsayed pushed a commit to moelsayed/kubermatic that referenced this pull request Oct 11, 2020
@multi-io @moelsayed
addon installer controller: update existing addons if needed (kuberma…
9fd0545 
…tic#5432)

Signed-off-by: Olaf Klischat <o.klischat@syseleven.de>
kubermatic-bot pushed a commit that referenced this pull request Oct 14, 2020
@moelsayed @multi-io
[release/v2.13] Add configurable default addon enforce option (#5987)
8be8202 
* Add configurable default addon enforce option

* Add configurable default addon enforce option

* addon installer controller: update existing addons if needed (#5432)

Signed-off-by: Olaf Klischat <o.klischat@syseleven.de>

* fix test

* ensure condition is set

* fix tests

* update prow config

* refactor

* disable by default

* review comments

Co-authored-by: Olaf Klischat <o.klischat@syseleven.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdomanski kdomanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.15
Development

Successfully merging this pull request may close these issues.
3 participants
@multi-io @kubermatic-bot @kdomanski