Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to in-tree cloud provider for OTC #5778

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fallback to in-tree cloud provider for OTC #5778

merged 2 commits into from
Aug 27, 2020

Conversation

irozzo-1A
Copy link
Contributor

@irozzo-1A irozzo-1A commented Aug 25, 2020 •
edited
Loading

What this PR does / why we need it:
When using OpenStack provider with Open Telekom Cloud we have to fallback to the in-tree cloud provider, otherwise services of type LoadBalancer do not work properly due to:

kubernetes/cloud-provider-openstack#960

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This is a temporary solution and should be removed when/if OTC will have a dedicated K8C provider.

Documentation:

Does this PR introduce a user-facing change?:

Fallback to in-tree cloud provider when OpenStack provider is used with Open Telekom Cloud

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. team/ui size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2020
@irozzo-1A irozzo-1A changed the title [WIP] Fallback to in-tree cloud provider for OTC Fallback to in-tree cloud provider for OTC Aug 26, 2020
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2020
xrstf
xrstf approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a37de608a2150d6c539acb60adeed2af30de34cb

@irozzo-1A
Copy link
Contributor Author

/retest

@zreigz
Copy link
Contributor

zreigz commented Aug 27, 2020

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, xrstf, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 05a0f1b into kubermatic:master Aug 27, 2020
@kubermatic-bot kubermatic-bot added this to the v2.15 milestone Aug 27, 2020
irozzo-1A added a commit to irozzo-1A/kubermatic-1 that referenced this pull request Aug 27, 2020
@irozzo-1A
Fallback to in-tree cloud provider for OTC (kubermatic#5778)
6decb24 
* Fallback to in-tree cloud provider for OTC

* Add unit test for isOTC function
@irozzo-1A irozzo-1A mentioned this pull request Aug 27, 2020
Merged
kubermatic-bot pushed a commit that referenced this pull request Aug 28, 2020
@irozzo-1A
Fallback to in-tree cloud provider for OTC (#5778) (#5797)
aab833c 
* Fallback to in-tree cloud provider for OTC

* Add unit test for isOTC function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.15
Development

Successfully merging this pull request may close these issues.
5 participants
@irozzo-1A @kubermatic-bot @zreigz @kubermatic-triage-bot @xrstf