Migrate vSphere CSIDriver resource on upgrade to match upstream
#12813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
|
/test pre-kubermatic-e2e-vsphere-ubuntu-1.28 |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/test pre-kubermatic-e2e-vsphere-ubuntu-1.28 |
wozniakjan
approved these changes
Nov 4, 2023
kubermatic-bot
added
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 93a93895b3e16b55a8df2751dab2436d2280c835
|
|
/hold cancel Since there's no full approval yet anyway. |
kubermatic-bot
removed
the
do-not-merge/hold
xrstf
reviewed
Nov 6, 2023
pkg/controller/seed-controller-manager/addon/addon_controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
LGTM label has been added. Git tree hash: 06c6b9066de83b283c7d4ed124fc7ab8675a3e8f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wozniakjan, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
embik
added
the
code-freeze-approved
kubermatic-bot
removed
the
do-not-merge/code-freeze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Settle down kids because this story might take a while.
Long back, #7280 added support for vSphere external CCM and CSI driver. CSI support was based on the 2.2.1 release of vsphere-csi-driver. For some reason that has been lost to history and the unwillingness to write proper PR descriptions, the original PR set
volumeLifecycleModeson theCSIDriverresource. This was not set in the corresponding upstream manifests for v2.2.1, and I cannot find any meaningful references tovolumeLifecycleModesin the upstream or k8c issue trackers.We have run into this exact problem (as described in #12801) once already: #8769 reverted settings to ensure that the
CSIDriverobject could be reconciled. I also don't see any reason why this needs to be set in those PRs, I suspect it was done simply because of the exact same error this PR is now trying to solve permanently.#12593 then upgraded the CSI driver to 3.0, and removed the
volumeLifecycleModessettings from theCSIDriveragain because the change was not documented and not matching upstream manifests.I've done some additional research and believe that the CSI driver does not support ephemeral volumes (which is indicated by
EphemeralinvolumeLifecycleModes), so the oldCSIDriverobject is incorrect.This PR adapts logic implemented in #12432 to also clean up the vSphere
CSIDriverobject to allow redeployment.Which issue(s) this PR fixes:
Fixes #12801
What type of PR is this?
/kind bug
/kind regression
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: