-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test if driver supports inline volumes in K8s 1.15 #20
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/assign @SandeepPissay |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Mind if i take this issue? @codenrhoden @SandeepPissay |
Sure! |
/assign @Alphasite |
@Alphasite: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@Alphasite: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ok, looks like this isn't supported in the vsphere-csi; this check fails:
I need to look a little more deeply into why this is failing, but in the process of digging into this work flow i found this related KEP and PR: kubernetes/enhancements#1698 & kubernetes/kubernetes#92784 which merged literally 2h ago and should provide a more generic implementation of ephemeral inline volumes. I'll figure out if supporting/testing this current implementation makes sense considering it will soon be superseded. |
@divyenpatel was working on CSI migration and I remember that the inline volumes are supported in CSI. @divyenpatel can you confirm? And can you also send some details on how you tested inline volumes in CSI? |
We have validated the migration of in-line in-tree volume to vSphere CSI Driver. In this case, the in-tree inline vSphere volume is presented as in-memory PV to CSI Driver, and thus volume attachment is created using volume path as volume handle.
We have not validated the CSI inline volume support using FCD ID specified in the pod spec. |
I dont have the testbed anymore, but i ran the k8s ephemeral-inline-volume e2e tests; i think it was this test suite. I also didn't explicitly specify a volume handle; I also tested manually with a spec similar to:
But with the sphere driver. I also enabled
Both manual and the e2e tests failed to create a pod with an inline ephemeral volume. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
With support for inline CSI volumes coming in K8s 1.15 (courtesy of @vladimirvivien), we need to test the CSI driver against that feature to see if works or if any changes are necessary.
The text was updated successfully, but these errors were encountered: