Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.54] Anexia Provider: Postpone machine cleanup when instance is still being created #1580

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[release/v1.54] Anexia Provider: Postpone machine cleanup when instance is still being created #1580

merged 1 commit into from
Mar 2, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1571

/assign ahmedwaleedmalik

Anexia Provider: fixed race condition in `Cleanup` method

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 2, 2023
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2023
Postpone machine cleanup when instance is still being created
f5d8753 
Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
@kubermatic-bot kubermatic-bot force-pushed the cherry-pick-1571-to-release/v1.54 branch from 6739a17 to f5d8753 Compare March 2, 2023 12:50
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: c49bc7d4d871532d01a14507d0a391e0108e782f

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kubermatic-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@kubermatic-bot kubermatic-bot merged commit ec3541b into kubermatic:release/v1.54 Mar 2, 2023
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1571-to-release/v1.54 branch October 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubermatic-bot @ahmedwaleedmalik