kubevirt: allow setting storage volume access types #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is important for live migration because only RWX volumes can be live migrated Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
kubermatic-bot
added
kind/feature
|
LGTM label has been added. Git tree hash: aa5177636df6c464a4c5fa7d2a49728bdb808349
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, wozniakjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
nrobert13
pushed a commit
to syseleven/machine-controller
that referenced
this pull request
Feb 21, 2024
this is important for live migration because only RWX volumes can be live migrated Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
ovstuckrad
pushed a commit
to syseleven/machine-controller
that referenced
this pull request
Feb 21, 2024
* Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (kubermatic#1731) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.42.0 to 0.46.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.42.0...zpages/v0.46.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migrate to dl.k8s.io from kubernetes release bucket (kubermatic#1737) Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Flatcar Support for GCE (kubermatic#1739) * Flatcar Support for GCE Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update compatibility matrix Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update Prow jobs to build image with Go 1.21.5 (kubermatic#1746) * Update Prow jobs to build image with Go 1.21.5 Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Also update golang images Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Also update Dockerfile and Makefile Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Update OSM flags Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Use fixed build image Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * ??? Signed-off-by: Marvin Beckers <marvin@kubermatic.com> --------- Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Deprecate sig-virtualization (kubermatic#1749) with merge of sig-virtualization into sig-cluster-management, there is no need for standalone OWNERS hierarchy for kubevirt Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * kubevirt: allow setting storage volume access types (kubermatic#1740) this is important for live migration because only RWX volumes can be live migrated Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * AWS: increase spot instance price (kubermatic#1754) Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Adds field to check if a IP reservation is still valid, (kubermatic#1753) if the IP is no longer valid a new one is requested. This fixes a bug where we use an IP that expired already for a VM, if the VM provisioning failed, which then leads to a race condition. In which we wait for the VM provisioning to finish, but it can't due the IP being no longer useable, but we also never request a new IP in that case. Signed-off-by: Zofia hagenguth <zhagenguth@anexia-it.com> * webhook: refactor to use controller-runtime server (kubermatic#1751) Refactor the webhook to use the controller-runtime provided webhook.Server instead of a plain HTTP server. The biggest benefit this brings, is it automatically loading changed certificate files instead of forever using the ones present when the server was started. This could have been implemented by using the controller-runtime CertWatcher manually, but that would've been more code and aligning machine-controller with the ecosystem-provided standards seems worth it. Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Support for Kubernetes 1.29 (kubermatic#1755) * Add support for kubernetes v1.29 Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update dependencies and k8s API to v1.29 Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Enable in-tree providers Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update fixtures Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Refactored code Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Upgrade to Go 1.22 (kubermatic#1759) * Upgrade to Go 1.22 Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Upgrade CRDs for OSM Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update prow jobs and remove yamllint image (kubermatic#1764) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove TORCX_BINDIR from containerd binary call (kubermatic#1760) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Support Edge Provider in Machine Controller (kubermatic#1765) * support edge provider Signed-off-by: Moath Qasim <moad.qassem@gmail.com> Signed-off-by: Moath Qasim <moad.qassem@gmail.com> * fix linting Signed-off-by: Moath Qasim <moad.qassem@gmail.com> Signed-off-by: Moath Qasim <moad.qassem@gmail.com> --------- Signed-off-by: Moath Qasim <moad.qassem@gmail.com> * fix syseleven changes * update fixtures * update go version in unit tests github workflow --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Zofia hagenguth <zhagenguth@anexia-it.com> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Signed-off-by: Moath Qasim <moad.qassem@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Andromeda <zofi@xamh.de> Co-authored-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Co-authored-by: Moath Qasim <moad.qassem@gmail.com> Co-authored-by: Robert Nemeti <r.nemeti@syseleven.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is important for live migration because only
RWXvolumes can be live migratedhttps://kubevirt.io/user-guide/operations/live_migration/#limitations
Which issue(s) this PR fixes:
see also: kubermatic/kubermatic#12860
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: