Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatcar Support for GCE #1739

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Flatcar Support for GCE #1739

merged 2 commits into from
Nov 29, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Nov 29, 2023 •
edited
Loading

What this PR does / why we need it:
Add Flatcar Linux support for GCE.

Reference: https://www.flatcar.org/docs/latest/installing/cloud/gcp/

Which issue(s) this PR fixes:

xref kubermatic/kubermatic#12728

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Flatcar is now supported on GCE

Documentation:

https://github.com/kubermatic/docs/pull/1599

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 29, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. docs/tbd Denotes a PR that needs documentation (change) that will be done later. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@ahmedwaleedmalik
Copy link
Member Author

ahmedwaleedmalik commented Nov 29, 2023 •
edited
Loading

Requires kubermatic/operating-system-manager#334

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review November 29, 2023 07:57
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@ahmedwaleedmalik
Flatcar Support for GCE
e1b65b8 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Update compatibility matrix
c491cdc 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
wozniakjan
wozniakjan approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44a4dcfb74fb1d61f02c5b0d6599a342864fc384

@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@kubermatic-bot kubermatic-bot merged commit c162be2 into kubermatic:main Nov 29, 2023
14 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the gce-flatcar branch November 29, 2023 10:32
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 6, 2024
nrobert13 pushed a commit to syseleven/machine-controller that referenced this pull request Feb 21, 2024
@ahmedwaleedmalik
Flatcar Support for GCE (kubermatic#1739)
3fae210 
* Flatcar Support for GCE

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update compatibility matrix

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

---------

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
ovstuckrad pushed a commit to syseleven/machine-controller that referenced this pull request Feb 21, 2024
@nrobert13 @dependabot
@ahmedwaleedmalik @embik @wozniakjan @89Q12 @LittleFox94 @moadqassem
K8s-9467 merge upstream v1.58.2 (#54)
b332154 
* Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (kubermatic#1731)

Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.42.0 to 0.46.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.42.0...zpages/v0.46.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Migrate to dl.k8s.io from kubernetes release bucket (kubermatic#1737)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Flatcar Support for GCE (kubermatic#1739)

* Flatcar Support for GCE

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update compatibility matrix

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

---------

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update Prow jobs to build image with Go 1.21.5 (kubermatic#1746)

* Update Prow jobs to build image with Go 1.21.5

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Also update golang images

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Also update Dockerfile and Makefile

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Update OSM flags

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Use fixed build image

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* ???

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

---------

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Deprecate sig-virtualization (kubermatic#1749)

with merge of sig-virtualization into sig-cluster-management, there is no need for standalone OWNERS hierarchy for kubevirt

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* kubevirt: allow setting storage volume access types (kubermatic#1740)

this is important for live migration because only RWX volumes can be live migrated

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* AWS: increase spot instance price (kubermatic#1754)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Adds field to check if a IP reservation is still valid, (kubermatic#1753)

if the IP is no longer valid a new one is requested.

This fixes a bug where we use an IP that expired already for a VM,
if the VM provisioning failed, which then leads to a race condition.
In which we wait for the VM provisioning to finish, but it can't due the IP being no longer useable,
but we also never request a new IP in that case.

Signed-off-by: Zofia hagenguth <zhagenguth@anexia-it.com>

* webhook: refactor to use controller-runtime server (kubermatic#1751)

Refactor the webhook to use the controller-runtime provided
webhook.Server instead of a plain HTTP server. The biggest benefit this
brings, is it automatically loading changed certificate files instead of
forever using the ones present when the server was started.

This could have been implemented by using the controller-runtime
CertWatcher manually, but that would've been more code and aligning
machine-controller with the ecosystem-provided standards seems worth it.

Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>

* Support for Kubernetes 1.29 (kubermatic#1755)

* Add support for kubernetes v1.29

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update dependencies and k8s API to v1.29

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Enable in-tree providers

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update fixtures

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Refactored code

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

---------

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Upgrade to Go 1.22 (kubermatic#1759)

* Upgrade to Go 1.22

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Upgrade CRDs for OSM

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

---------

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

* Update prow jobs and remove yamllint image (kubermatic#1764)

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Remove TORCX_BINDIR from containerd binary call (kubermatic#1760)

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

* Support Edge Provider in Machine Controller (kubermatic#1765)

* support edge provider
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

* fix linting
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

---------

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

* fix syseleven changes

* update fixtures

* update go version in unit tests github workflow

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Zofia hagenguth <zhagenguth@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Co-authored-by: Marvin Beckers <marvin@kubermatic.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Co-authored-by: Andromeda <zofi@xamh.de>
Co-authored-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Co-authored-by: Moath Qasim <moad.qassem@gmail.com>
Co-authored-by: Robert Nemeti <r.nemeti@syseleven.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees

@wozniakjan wozniakjan

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @wozniakjan