Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hcloud: Allow configuring labels #576

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Hcloud: Allow configuring labels #576

merged 1 commit into from
Jun 17, 2019

Conversation

alvaroaleman
Copy link
Contributor

What this PR does / why we need it:

Allows to configure labels for hcloud/hetzner machines

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

none

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2019
@alvaroaleman
Hcloud: Allow configuring labels
b915391 
Signed-off-by: Alvaro Aleman <alv2412@googlemail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jun 17, 2019
@mrIncompetent
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b24708ef1b4cb783d1764c43dffb77c99bce6c7

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrIncompetent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@alvaroaleman
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 40bdc3f into master Jun 17, 2019
@kubermatic-bot kubermatic-bot deleted the hcloud-metadata branch June 17, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrIncompetent mrIncompetent Awaiting requested review from mrIncompetent

Assignees

@mrIncompetent mrIncompetent

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvaroaleman @mrIncompetent @kubermatic-bot