Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatcar Support for GCE #334

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Flatcar Support for GCE #334

merged 1 commit into from
Nov 29, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Nov 29, 2023 •
edited

What this PR does / why we need it:
This "whitelists" flatcar for GCE cloud provider. We don't need any changes other than just adding GCE as a supported cloud provider in the default flatcar OSP.

Which issue(s) this PR fixes:

xref kubermatic/kubermatic#12728

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Flatcar is now supported on GCE

Documentation:

https://github.com/kubermatic/docs/issues/1599

@ahmedwaleedmalik
Flatcar Support for GCE
a857468 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 29, 2023
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Nov 29, 2023
Merged
wozniakjan
wozniakjan approved these changes Nov 29, 2023
View reviewed changes
Copy link

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cff1e9782e94decee8d3e7c7c0d125289da73048

@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@kubermatic-bot kubermatic-bot merged commit 7b7f7b3 into kubermatic:main Nov 29, 2023
10 of 11 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the gce-flatcar branch November 29, 2023 07:57
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@wozniakjan wozniakjan

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @wozniakjan