Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.CodeAnalysis.CSharp from 4.0.1 to 4.2.0 #918

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2022

Bumps Microsoft.CodeAnalysis.CSharp from 4.0.1 to 4.2.0.

Release notes

Sourced from Microsoft.CodeAnalysis.CSharp's releases.

.NET 7.0 Preview 5

Release

.NET 7.0 Preview 2

Release

.NET 7.0 Preview 1

Release

Changelog

Sourced from Microsoft.CodeAnalysis.CSharp's changelog.

Version 4.2.0

Can no longer inherit from QuickInfoService

The constructors of Microsoft.CodeAnalysis.QuickInfoService are now internal. Roslyn does not support implementing completion for arbitrary languages.

Microsoft.CodeAnalysis.CodeStyle.NotificationOption is now immutable

All property setters now throw an exception.

Commits
  • 432d17a Cherry-pick 60493 to 17.2 (#60832)
  • 1e40aa1 Merge pull request #60851 from CyrusNajmabadi/revert60227
  • db85d9e Revert "Don't complete quotes if they complete a valid string (#60227)"
  • f2d278f Merge pull request #60712 from dotnet/dev/jorobich/use-vs2022-official-build
  • 1a20e23 Fix image name
  • 16b2f8f Use VS2022 for official build
  • 76398ad Fix crash when combining reordered arguments with params array (#60590)
  • aeafe4d Check val escape for initializers of fields with ref-like type (#60577)
  • 8b5c5b8 Merge pull request #60531 from jasonmalinowski/do-not-pass-idynamicfileinfo-f...
  • fb7998f Remove IDynamicFileInfo-added syntax trees to attempt to improve perf
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2022
@m3nax
Copy link
Contributor

m3nax commented Jul 9, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.CSharp-4.2.0 branch from 993d58a to da88168 Compare July 9, 2022 11:41
@brendandburns
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.CSharp-4.2.0 branch from da88168 to 08d1d50 Compare August 15, 2022 15:31
@m3nax
Copy link
Contributor

m3nax commented Aug 29, 2022

https://github.com/dependabot rebase

Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.0.1 to 4.2.0.
- [Release notes](https://github.com/dotnet/roslyn/releases)
- [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md)
- [Commits](dotnet/roslyn@v4.0.1...v4.2.0)

---
updated-dependencies:
- dependency-name: Microsoft.CodeAnalysis.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.CSharp-4.2.0 branch from 08d1d50 to 0768e7c Compare August 29, 2022 17:37
@m3nax
Copy link
Contributor

m3nax commented Aug 30, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2022

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@m3nax
Copy link
Contributor

m3nax commented Aug 30, 2022

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2022

Sorry, only users with push access can use that command.

@m3nax
Copy link
Contributor

m3nax commented Aug 30, 2022

Can you re-run CI step Build and Test / e2e (pull_request) please?
I think it is a transient error generated by the slowness of the github runner.
Error: https://github.com/kubernetes-client/csharp/runs/8076417357?check_suite_focus=true#step:7:78

Test code:

int retry = 5;
while (retry-- > 0)
{
try
{
await genericPods.DeleteNamespacedAsync<V1Pod>(namespaceParameter, podName).ConfigureAwait(false);
}
catch (HttpOperationException e)
{
if (e.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
{
return;
}
}
pods = await genericPods.ListNamespacedAsync<V1PodList>(namespaceParameter).ConfigureAwait(false);
if (!pods.Items.Any(p => p.Metadata.Name == podName))
{
break;
}
await Task.Delay(TimeSpan.FromSeconds(2.5)).ConfigureAwait(false);
}
Assert.DoesNotContain(pods.Items, p => p.Metadata.Name == podName);

@brendandburns @tg123

@m3nax
Copy link
Contributor

m3nax commented Aug 30, 2022

@tg123 Thank, all checks are green.

Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 24caa9b into master Aug 30, 2022
@dependabot dependabot bot deleted the dependabot/nuget/Microsoft.CodeAnalysis.CSharp-4.2.0 branch August 30, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants