Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CHANGELOG and README #1254

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Update the CHANGELOG and README #1254

merged 1 commit into from
Sep 15, 2020

Conversation

palnabarun
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2020
@palnabarun
Copy link
Member Author

/assign @roycaihw

@yliaog
Copy link
Contributor

yliaog commented Sep 9, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2020
@iciclespider
Copy link
Contributor

Port forwarding is a new feature.

@yliaog
Copy link
Contributor

yliaog commented Sep 10, 2020

port forwarding is likely going into the next release

@iciclespider
Copy link
Contributor

port forwarding is likely going into the next release

But this is being merged into master, and port forwarding is also in master.

@palnabarun
Copy link
Member Author

/retest

@palnabarun
Copy link
Member Author

But this is being merged into master, and port forwarding is also in master.

Indeed this is being merged to master. But, they are CHANGELOGs from previous client releases. Whenever we release a new version of the client, the port forwarding related stuff would be mentioned.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@palnabarun
Update the CHANGELOG and README
de822a2 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Copy link
Member Author

@yliaog @roycaihw -- Need an LGTM again since I force pushed to re-run Travis builds.

@yliaog
Copy link
Contributor

yliaog commented Sep 15, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 457ac54 into kubernetes-client:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@palnabarun @yliaog @iciclespider @k8s-ci-robot @roycaihw