Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python base #1220

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Update python base #1220

merged 1 commit into from
Jul 30, 2020

Conversation

greed42
Copy link
Contributor

@greed42 greed42 commented Jul 30, 2020

To get auth plugin support for client certificates, ref. kubernetes-client/python-base#205

@greed42
Update python base
5424e17 
To get auth plugin support for client certificates, ref. kubernetes-client/python-base#205
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @greed42!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2020
@greed42
Copy link
Contributor Author

greed42 commented Jul 30, 2020

/assign @roycaihw

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: greed42, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit b5603d8 into kubernetes-client:master Jul 30, 2020
palnabarun added a commit to palnabarun/python that referenced this pull request Aug 19, 2020
@palnabarun
Update the CHANGELOG and README
48230f3 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun added a commit to palnabarun/python that referenced this pull request Sep 9, 2020
@palnabarun
Update the CHANGELOG and README
ce6a89d 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun mentioned this pull request Sep 9, 2020
Merged
palnabarun added a commit to palnabarun/python that referenced this pull request Sep 15, 2020
@palnabarun
Update the CHANGELOG and README
de822a2 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
abdul5497 pushed a commit to abdul5497/python-dapp that referenced this pull request Apr 1, 2024
Update the CHANGELOG and README
4dd60d4 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client/python#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greed42 @k8s-ci-robot @roycaihw