Moves iscsi csi-driver from kubernetes-csi/drivers mono-repo #2
Conversation
Add some unit tests & improve logging
refactor csi-common and hostpath plugin to use new api objects
This patch updates the README for plugins for CSI 0.2.0. It includes the following changes: - Updates the CSC tool location - Removes "get supported versions" because that was removed from CSI.
Update CSI Plugins README
Update image links for NFS
The AttachDisk and DetachDisk methods were appending volume name to the supplied target path which was causing the disk to be mounted at wrong path. Further the unmounting of the disk fails as kubelet could not find any mounted device at the actual mount path. This commit removes the appended volume name.
Fix mount/unmount path of iscsi driver.
Update to CSI 0.3
Update drivers to pick up CSI 1.0.0
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
|
/assign @j-griffith |
|
@msau42: GitHub didn't allow me to assign the following users: j-griffith. Note that only kubernetes-csi members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
prateekpandey14
force-pushed
the
iscsi-driver
branch
from
6bfaeda
to
0e2bc98
Compare
|
@prateekpandey14 Cool! Thanks for putting all the commit history together. There are a number of things still needed (capabilities etc) but this seems like a good initial move of the existing code to work from. I'd propose merging this and then working on the remaining pieces and updates. /LGTM |
|
@j-griffith: changing LGTM is restricted to assignees, and only kubernetes-csi/csi-driver-iscsi repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prateekpandey14, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
README.md: fix repo URL for initial setup
…owners add myself to owners
This PR is to setup and migrate the ISCSI CSI driver from drivers mono repo to its own repository.