Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set up sanity test and fix sanity test failures #67

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This PR sets up sanity test and fix sanity test failures
After this PR merged, I will set up sanity test pipeline

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • before fix
Summarizing 12 Failures:

[Fail] Node Service NodePublishVolume [It] should fail when no volume id is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:390

[Fail] Node Service NodePublishVolume [It] should fail when no target path is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:405

[Fail] Node Service NodePublishVolume [It] should fail when no volume capability is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:422

[Fail] Node Service NodeUnpublishVolume [It] should fail when no volume id is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:432

[Fail] Node Service NodeUnpublishVolume [It] should fail when no target path is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:446

[Fail] Node Service [It] should work
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:91

[Fail] Node Service [It] should be idempotent
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:91

[Fail] Controller Service [Controller Server] ControllerGetCapabilities [It] should return appropriate capabilities
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:151

[Fail] Controller Service [Controller Server] ValidateVolumeCapabilities [It] should fail when no volume id is provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:744

[Fail] Controller Service [Controller Server] ValidateVolumeCapabilities [It] should fail when no volume capabilities are provided
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:753

[Fail] Controller Service [Controller Server] ValidateVolumeCapabilities [It] should return appropriate values (no optional values added)
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:788

[Fail] Controller Service [Controller Server] ValidateVolumeCapabilities [It] should fail when the requested volume does not exist
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:840

Ran 17 of 77 Specs in 0.127 seconds
FAIL! -- 5 Passed | 12 Failed | 1 Pending | 59 Skipped
  • after fix
S [SKIPPING] in Spec Setup (BeforeEach) [0.002 seconds]
Node Service
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/tests.go:44
  NodeExpandVolume
  /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:674
    should fail when volume is not found [BeforeEach]
    /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:716

    NodeExpandVolume not supported

    /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/node.go:677
------------------------------
SSSSSSSSSSSSSSSSSSSSS
Ran 10 of 77 Specs in 0.055 seconds
SUCCESS! -- 10 Passed | 0 Failed | 0 Pending | 67 Skipped

Does this PR introduce a user-facing change?:

test: set up sanity test and fix sanity test failures

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2021
@andyzhangx andyzhangx force-pushed the fix-sanity-test branch 3 times, most recently from 94ab3fe to c3813a3 Compare October 17, 2021 10:57
fix sanity test failure

fix test failure

skip one test
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec
Copy link
Contributor

humblec commented Oct 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d54607 into kubernetes-csi:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants