-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fsgroup in CSI calls; enable fsgroup e2e tests #379
Conversation
Pull Request Test Coverage Report for Build 1498821454
💛 - Coveralls |
/retest |
fix test failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for delegating pod fsgroup information to CSI driver. The implementation is the same as AzureFile cifs mode. Main goal is to improve test coverage of the fsgroup delegating feature by running fsgroup tests against the SMB CSI driver in k8s CSI CI.
Which issue(s) this PR fixes:
Fixes #345
Requirements:
Special notes for your reviewer:
Unit tests were skipped here because there was no precedence in FakeMounter to plumb out the function parameters. Let me know if you prefer to add this in.
Release note:
/assign @andyzhangx