Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fsgroup in CSI calls; enable fsgroup e2e tests #379

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Nov 24, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:

Adds support for delegating pod fsgroup information to CSI driver. The implementation is the same as AzureFile cifs mode. Main goal is to improve test coverage of the fsgroup delegating feature by running fsgroup tests against the SMB CSI driver in k8s CSI CI.

Which issue(s) this PR fixes:

Fixes #345

Requirements:

Special notes for your reviewer:

Unit tests were skipped here because there was no precedence in FakeMounter to plumb out the function parameters. Let me know if you prefer to add this in.

Release note:

feat: Support fsgroup in CSI calls

/assign @andyzhangx

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2021
@coveralls
Copy link

coveralls commented Nov 24, 2021

Pull Request Test Coverage Report for Build 1498821454

  • 9 of 19 (47.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 85.487%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 8 18 44.44%
Totals Coverage Status
Change from base Build 1498314355: -0.8%
Covered Lines: 807
Relevant Lines: 944

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 24, 2021
@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 35357c4 into kubernetes-csi:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Volume_mount_group capability
4 participants