-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make image.*.repository variables relative by default #797
make image.*.repository variables relative by default #797
Conversation
|
Welcome @amarkevich! |
Hi @amarkevich. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 9793750705Details
💛 - Coveralls |
/ok-to-test |
what's the point of this PR? csi-driver-smb/charts/latest/csi-driver-smb/templates/csi-smb-controller.yaml Lines 56 to 60 in 999ac2b
|
To use 'baseRepo' all the 'image.*.repository' values should be relative. |
@amarkevich this is already supported today |
@andyzhangx now its not enough to set 'baseRepo' to switch image repository completely but all 'image.*.repository' values should be changed to be relative. This PR make it by default |
image.baseRepo can be used to specify the registry once
0ac20e8
to
d581d0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amarkevich, andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 9986357539Details
💛 - Coveralls |
What type of PR is this?
/kind feature
What this PR does / why we need it:
image.baseRepo
can be used to specify the registry onceWhich issue(s) this PR fixes:
none
Requirements:
Special notes for your reviewer:
Release note: