-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use MakeCreateVolumeReq() #524
base: master
Are you sure you want to change the base?
Conversation
Use MakeCreateVolumeReq for all tests that does not care how volumes are created. This fixes several places where TestVolumeSize is not considered. MakeCreateVolumeReq() itself is modified to not pass LimitBytes, to match most existing cases.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
) | ||
req2 := MakeCreateVolumeReq(sc, name) | ||
req2.CapacityRange = &csi.CapacityRange{ | ||
RequiredBytes: TestVolumeSize(sc) * 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to fix MakeCreateVolumeReq to take CapacityRange as input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 41 usages of MakeCreateVolumeReq now. Do we really want to make 40 invocations more complex to simplify one case?
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Use MakeCreateVolumeReq for all tests that does not care how volumes are created.
This fixes several places where TestVolumeSize is not considered.
MakeCreateVolumeReq() itself is modified to not pass LimitBytes, to match most existing cases.
Which issue(s) this PR fixes:
Fixes some failures due to TestVolumeSize not passed to CSI.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: