Fix data race in cloning protection controller

[tksm]

What type of PR is this?
/kind bug

What this PR does / why we need it:
As mentioned in #590, informers will automatically start when factory.Start is called. Since calling the extra claimInformer.Run causes a data race, it should not be called in CloningProtectionController. I think this PR along with #590 will fix #582.

Which issue(s) this PR fixes:

Fixes #595

Special notes for your reviewer:

#595 (comment) is my reproduction code to produce a similar panic to #582 by calling informer.Run() twice.

Does this PR introduce a user-facing change?:

Fix a data race in cloning protection controller

[k8s-ci-robot]

Welcome @tksm!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tksm. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/ok-to-test

[pohly]

/lgtm

[pohly]

/assign @msau42

For approval.

[msau42]

/lgtm
/approve

[msau42]

This is not related to this change, but I think it's better that we move adding the claimHandler to the New function so that this Run function does not depend on ordering of the other Run functions.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, tksm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment