Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set namespace on switching context #107

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

darth10
Copy link
Contributor

@darth10 darth10 commented Oct 31, 2019

I noticed that the namespace is reset to default on switching context.
If the default namespace has been customized, it should be used instead.

Related to #104.

More than happy to make any changes!

@darth10
Copy link
Contributor Author

darth10 commented Oct 31, 2019

Looks like the build is failing on trying to install undo-tree for evil 🤔

Installing [ 8/9] evil (latest)... downloadingDependency evil failed to install: Package ‘undo-tree-0.6.3’ is unavailable

@noorul
Copy link
Collaborator

noorul commented Oct 31, 2019

Can you re-base?

@darth10 darth10 force-pushed the fix/namespace-on-use-context branch from c915e60 to ec50908 Compare October 31, 2019 18:54
@darth10
Copy link
Contributor Author

darth10 commented Oct 31, 2019

Done!
Thanks for fixing the build error @noorul.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 29.877% when pulling ec50908 on darth10:fix/namespace-on-use-context into ea4b25c on chrisbarrett:master.

@darth10
Copy link
Contributor Author

darth10 commented Nov 8, 2019

@chrisbarrett @noorul Can this be merged if it looks alright?

Copy link
Collaborator

@noorul noorul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noorul noorul merged commit 9d8ef64 into kubernetes-el:master Nov 8, 2019
@darth10 darth10 deleted the fix/namespace-on-use-context branch November 8, 2019 06:18
jinnovation pushed a commit to jinnovation/kubernetes-el that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants