Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #69.
Currently, we define one function for
get
ting all entities of a given resource type, for each of a finite set of resources, e.g.k8s-kubectl-get-{pods, nodes, ...}
. All of these functions are identical save for the resource type that they retrieve.As such, we generalize to a single implementation—
k8s-kubectl-get
—that accepts the resource type name and performs theget
accordingly.By extension, we rewire all call sites that assume the existence of per-type
get
functions to use the genericized counterpart—most notably thekubernetes-state-define-refreshers
macro, which currently literally expects functions of those naming pattern to exist.Similarly, we consolidate unit tests and, finally, remove the granular, per-type
get
functions.